Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change jobManagement to new jobDefentions (MAPCO-5091) #98

Merged
merged 8 commits into from
Oct 31, 2024
Merged

refactor: change jobManagement to new jobDefentions (MAPCO-5091) #98

merged 8 commits into from
Oct 31, 2024

Conversation

razbroc
Copy link
Contributor

@razbroc razbroc commented Oct 30, 2024

Question Answer
Bug fix ✖
New feature ✖
Breaking change ✔
Deprecations ✖
Documentation ✖
Tests added ✖
Chore ✔

Related issues: MAPCO-5091

@razbroc razbroc self-assigned this Oct 30, 2024
CL-SHLOMIKONCHA
CL-SHLOMIKONCHA requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didnt change the default.json config file..

config/custom-environment-variables.json Outdated Show resolved Hide resolved
helm/values.yaml Outdated Show resolved Hide resolved
@razbroc razbroc requested a review from RonitKissis October 31, 2024 08:41
@razbroc razbroc merged commit e3d26ef into master Oct 31, 2024
9 checks passed
@razbroc razbroc deleted the apply-jobDefenition branch October 31, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonitKissis RonitKissis RonitKissis approved these changes

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA CL-SHLOMIKONCHA approved these changes

Assignees

@razbroc razbroc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razbroc @CL-SHLOMIKONCHA @RonitKissis