feat: fix order for footprint vs bbox and other cr requests #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asafMasa
commented
Dec 15, 2022
asafMasa
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✖ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✖ |
| Tests added | ✖ |
| Chore | ✔ |
| private sanitizeBbox(bbox: BBox, footprint: Polygon | MultiPolygon, zoom: number): BBox2d | null { | ||
| const intersaction = intersect(bboxPolygon(bbox), footprint); | ||
|
|
||
| private isAPolygon(obj?: object): obj is Polygon { |
There was a problem hiding this comment.
add logic to assert valid footprint, in case of failure throw 400
ronenkapelian
approved these changes
Dec 18, 2022
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const geojsonhint: IHinter = require('@mapbox/geojsonhint') as IHinter; |
There was a problem hiding this comment.
why it isn't on top with other importing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.