fix: trigger bug fixes #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafMasa
requested changes
Nov 13, 2022
| const jobCreated = await this.jobManagerClient.create(workerInput); | ||
| return jobCreated; | ||
| } else if (duplicationExist.status === OperationStatus.COMPLETED) { |
There was a problem hiding this comment.
i would have written
if (duplicationExist && duplicationExist.status === OperationStatus.COMPLETED) { // for completed
const completeResponseData = duplicationExist as ICallbackResponse;
completeResponseData.bbox = bbox;
return duplicationExist;
} else if (duplicationExist) { // for in progress
return duplicationExist;
}
// else rest of the code (not duplicationExist) without an if
const batches: ITileRange[] = [];
for (let i = 0; i <= zoomLevel; i++) {
...
...
asafMasa
requested changes
Nov 13, 2022
| return duplicationExist; | ||
| } else if (duplicationExist) { | ||
| return duplicationExist; | ||
| } else { |
There was a problem hiding this comment.
you don't need the "else { " condition - remove it as it's obvious
asafMasa
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating logic for returning callbacks on case of existing (naive cache)
scenarios:
Send GPKG request
1.No job is in progress with those parameters - create new
2.Job is In progress - return “In Progress“
3.Job completed not cleaned return callback response
4.Job completed - cleaned - same as “a”
Bug fixes: