Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added polling jobs status system #31

Merged
merged 10 commits into from
Sep 5, 2022
Merged

Conversation

CL-SHLOMIKONCHA
Copy link
Contributor

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA commented Aug 23, 2022

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

Add Job done logic:

  • Call the callback URI’s instead of worker
  • when GPKG creation is finished - JSON serialize the raster “record“ object to json file named metadata.json in the same location
  • Set Job success // fail
  • Helm
  • Tests

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2022

This pull request introduces 7 alerts when merging 4fcdad4 into 786bccc - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

Copy link
Contributor

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

helm/values.yaml Outdated Show resolved Hide resolved
helm/values.yaml Outdated Show resolved Hide resolved
src/clients/callbackClient.ts Show resolved Hide resolved
src/common/enums.ts Outdated Show resolved Hide resolved
src/common/interfaces.ts Outdated Show resolved Hide resolved
src/pollingManager.ts Outdated Show resolved Hide resolved
src/tasks/interfaces.ts Outdated Show resolved Hide resolved
src/tasks/models/tasksManager.ts Outdated Show resolved Hide resolved
src/pollingManager.ts Outdated Show resolved Hide resolved
src/tasks/models/tasksManager.ts Show resolved Hide resolved
src/common/interfaces.ts Outdated Show resolved Hide resolved
src/common/utils.ts Outdated Show resolved Hide resolved
src/common/utils.ts Show resolved Hide resolved
src/createPackage/models/createPackageManager.ts Outdated Show resolved Hide resolved
src/createPackage/models/createPackageManager.ts Outdated Show resolved Hide resolved
src/pollingManager.ts Outdated Show resolved Hide resolved
src/pollingManager.ts Outdated Show resolved Hide resolved
src/tasks/models/tasksManager.ts Outdated Show resolved Hide resolved
src/tasks/models/tasksManager.ts Show resolved Hide resolved
src/tasks/models/tasksManager.ts Outdated Show resolved Hide resolved
helm/values.yaml Outdated Show resolved Hide resolved
src/clients/callbackClient.ts Show resolved Hide resolved
Copy link
Contributor

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

src/tasks/models/tasksManager.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@cl-shaharshavit-rnd cl-shaharshavit-rnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work on tests

FIX LINT!!!

src/createPackage/models/createPackageManager.ts Outdated Show resolved Hide resolved
tests/unit/createPackage/models/createPackageModel.spec.ts Outdated Show resolved Hide resolved
tests/unit/createPackage/models/createPackageModel.spec.ts Outdated Show resolved Hide resolved
@CL-SHLOMIKONCHA CL-SHLOMIKONCHA merged commit 11960f1 into master Sep 5, 2022
@CL-SHLOMIKONCHA CL-SHLOMIKONCHA deleted the polling-jobs-status branch September 5, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants