Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add map components documentation #97

Merged
merged 35 commits into from
Nov 21, 2024

Conversation

shimoncohen
Copy link
Contributor

No description provided.

@shimoncohen shimoncohen added the documentation Improvements or additions to documentation label Oct 10, 2024
@shimoncohen shimoncohen self-assigned this Oct 10, 2024
@shimoncohen shimoncohen marked this pull request as draft October 10, 2024 17:08
Copy link

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-21 23:19 UTC

@shimoncohen
Copy link
Contributor Author

I think we need to add the versions for each map component for which this information is on.

@shimoncohen shimoncohen marked this pull request as ready for review October 10, 2024 18:18
docs/KnowledgeBase/MapViewers/map-components.md Outdated Show resolved Hide resolved
docs/KnowledgeBase/MapViewers/README.md Outdated Show resolved Hide resolved
docs/KnowledgeBase/MapViewers/README.md Outdated Show resolved Hide resolved
docs/KnowledgeBase/MapViewers/README.md Outdated Show resolved Hide resolved
docs/KnowledgeBase/MapViewers/README.md Outdated Show resolved Hide resolved
@CptSchnitz CptSchnitz changed the title feat: add map component documentation feat: add map components documentation Oct 13, 2024
netanelC
netanelC previously approved these changes Oct 13, 2024
Copy link
Contributor

@CptSchnitz CptSchnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add some note that its only Web viewers, not mobile

@@ -0,0 +1,3 @@
{
"position": 2
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N
E
W
L
I
N
E

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A
D
D
E
D
!


OpenLayers - [Docs](https://openlayers.org/en/latest/apidoc/), [Examples](https://openlayers.org/en/latest/examples/), [Playground](https://codesandbox.io/examples/package/openlayers)

EsriJS - [Docs](https://developers.arcgis.com/javascript/latest/), [Examples](https://developers.arcgis.com/javascript/latest/sample-code/), [Playground](https://developers.arcgis.com/javascript/3/samples/playground/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arcgis sdk not esrijs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

docs/KnowledgeBase/MapViewers/map-components.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap between what is map compontent and whining about so many

Copy link
Contributor Author

@shimoncohen shimoncohen Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapped.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add short summary of the common map viewers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this map to be Comparison

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and I think that adding a TOC in the page isn't relevant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change with comparison.

| ----------- | ----------- | ----------- | ----------- | ----------- | ----------- | ----------- | ----------- |
| Cesium | ✅ | ❌ | ✅ | ❌ | ✅ | | |
| Leaflet | ✅ | ❌ | ✅ | ➖ Possible with package or TileLayer Hack | ✅ | | |
| OpenLayers | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.


### Supported data types and protocols

| **Viewer** | **WMS** | **Can read WMS capabilities** | **WMTS** | **Can read WMTS capabilities** | **Tile Layer** | **GeoTiff** | **COG** |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

@shimoncohen shimoncohen requested a review from netanelC October 13, 2024 17:58
Copy link

@nirolevy nirolevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to explicitly re-define the goal and the clients, and use ChatGPT to make sure it's understandable even for the dumbest of clientes


A map viewer is a visual component to help us display `geographic` data such as raster, vector, 3D and DEM. It does all of the heavy-lifting in fetching, calculating and displaying the data correctly.

There are many features that a map viewer could implement, please read more about the different libraries and features [here](/docs/KnowledgeBase/MapViewers/map-components.md).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"please read"-> "to read"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, relative links will probably be more robust

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


### OpenLayers 🆓

An open-source JavaScript library for displaying map data in web browsers as slippy maps. It provides an API for building rich web-based geographic applications similar to Google Maps and Bing Maps.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Slippy map" is not yet defined


### ArcGIS JS SDK 💰

ArcGIS is a family of client, server and online geographic information system (GIS) software developed and maintained by Esri.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GIS" is not yet defined


ITowns is a javascript framework for 3D geographic data visualisation. It can display a wide range of data such as ortho-images, Digital Elevation Models (DEM) or 3D models.

ITowns is based on Three.js, which is a javascript library that implements WebGL to render sophisticated 3D Geometry on a webpage.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three.js does not implement WebGL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## Projections

If you don't know what a `projection` is, please read more [here](/docs/KnowledgeBase/terms#mapping), or on [wikipedia 🌐](https://en.wikipedia.org/wiki/Map_projection).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link terms in header and give o short explaination here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, explain about the MC projections?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, EPSG: 4326 is NOT a projection, but a geographic CRS.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, define "reproject"


### Supported data types and protocols

| **Viewer** | **WFS** | **GeoJSON** | **Features** | **Drawing** |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many empty cells...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are there to fill in the future. They are currently unknown and will slowly be added.


### Vector Tiles

| **Viewer** | **Query** | **Symbology** | **OGC Vector Tiles** |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's OGC vector tiles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some information.

| OpenLayers | ✅ | ❌ | ✅ |
| ArcGIS JS SDK | ✅ | ✅ | ❌ |
| iTowns | ✅ | ❌ | ❌ |
| Mapbox v1 | ✅ | ✅ But for v1 | ❌ |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats v1?

| **Viewer** | **Query** | **Symbology** | **OGC Vector Tiles** |
| ----------- | ----------- | ----------- | ----------- |
| Cesium | ❌ | ❌ | ❌ |
| Leaflet | ❌ | | ❌ |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's not ture? I'll check again, this could be outdated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tetris somehow does leaflet+mvt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is support for vector tiles with some plugins, added.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Consider running through chatGPT for fact-checking
  2. Consider unifying to "formats" and "features" tables, for simplicity
  3. Consider making the tables "smart" (i.e. ability to interactively choose columns)
  4. Consider running through chatGPT for formatting uniformity

docs/KnowledgeBase/MapViewers/README.md Outdated Show resolved Hide resolved
netanelC
netanelC previously approved these changes Oct 20, 2024
@syncush
Copy link
Contributor

syncush commented Oct 29, 2024

when is it gonna be merged? @shimoncohen

@shimoncohen shimoncohen requested a review from netanelC October 30, 2024 19:13
@syncush
Copy link
Contributor

syncush commented Nov 17, 2024

bump , when will it be merged? @shimoncohen

netanelC
netanelC previously approved these changes Nov 19, 2024
@netanelC netanelC self-requested a review November 19, 2024 07:11
@shimoncohen shimoncohen merged commit 55de8fd into master Nov 21, 2024
2 checks passed
@shimoncohen shimoncohen deleted the add-map-component-documentation branch November 21, 2024 23:18
@@ -18,6 +18,11 @@ tags:

In this page we list some features that you may be interested in and show which map viewers support them.

:::caution
Not all mentioned featuresare supported by MapColonies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants