fix: support null valued config attributes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-32d4fbf1813ec56bcebe7e3786fad46011424e2b.tgz"
}
}The link will expire in a week ⌛ |
CptSchnitz
requested changes
Dec 9, 2024
tests/helpers.spec.ts
Outdated
| const action = () => { | ||
| data.name = 'i try to change'; // try to change freezed object | ||
| }; | ||
| expect(action).toThrow(/Cannot assign to read only property/); |
There was a problem hiding this comment.
only if we had an assertion to check if object is frozen 🤔
Co-authored-by: Ofer <[email protected]>
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-0b3dc92ae3b030c88ba41d8446c40523217cb41b.tgz"
}
}The link will expire in a week ⌛ |
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-d8ec119499154cd767ac9d61b920ae4f1a9799ae.tgz"
}
}The link will expire in a week ⌛ |
CptSchnitz
approved these changes
Dec 11, 2024
|
good job son |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deepFreeze couldn't support with null valued attributes.
Added null validation on freeze objects