feat: initial api #2

CptSchnitz · 2024-06-20T15:10:16Z

This is first version without testing yet, the review should not be merged yet.

github-actions · 2024-06-20T18:12:44Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-056bb14c634365027ee0e5c12f0812e00cd1e80c.tgz"
  }
}

The link will expire in a week ⌛

syncush

Some of the code has JSDoc and some doesn't, let's go all for JSDoc!
Tests?

syncush · 2024-06-21T11:40:32Z

src/debug.ts

+import debug from 'debug';
+
+export function createDebug(name: string): debug.Debugger {
+    return debug(`@map-colonies/config:${name}`);
+}


I'm not too fond of it being in the main files hierarchy

moved to util

syncush · 2024-06-21T11:42:33Z

src/constants.ts

+import { readPackageJsonSync } from '@map-colonies/read-pkg';
+
+const schemasPackagePathBuildPath = require.resolve('@map-colonies/schemas').substring(0, require.resolve('@map-colonies/schemas').indexOf('build'));
+export const LOCAL_SCHEMAS_PACKAGE_VERSION = readPackageJsonSync(schemasPackagePathBuildPath + 'package.json').version as string;


should we use path. join?

src/env.ts

.vscode/settings.json

src/env.ts

src/options.ts

src/debug.ts

src/env.ts

github-actions · 2024-06-26T07:25:44Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-50eb954f8e0403d61972d1b4bad05cb90ba29104.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-06-26T12:22:04Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-acc5f5f9caf010d2337792ccd56fb6857e507249.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-06-27T05:38:15Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-3706662a3d86a5b8b1571d2f4e1d34c139dd8e7f.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-06-27T12:24:51Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-d8a657aa1c994167a383307efbf7e468ebe50863.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-06-27T12:54:49Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-865c69e9aad168f114771062beebd0fd8e841620.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-06-30T04:46:58Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-71674559ed69428ea1bdc3914f98b287609d760a.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-06-30T04:52:05Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-fb883c3b9f92cb957a7cf33c6d1b4f0e94489aad.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-07-04T05:48:39Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-13c28def501490deb28d0687e3e91a908e113d1f.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-07-04T12:14:00Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-75a5af4ca302a434771cb9c79118e92975caacf0.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-07-07T13:48:23Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-f5318aa4e443db4c34344120287208d9195424d8.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-07-08T12:17:43Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-baacb7eef75640776137b101422c645bae76daed.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-07-09T13:31:40Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-0d61d0b759173e3bdc4baf4d852db38b7da041e7.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-07-10T05:05:17Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-41956f3cf7e0565a6c983bd74e74fcb605dc7775.tgz"
  }
}

The link will expire in a week ⌛

tests/config.spec.ts

tests/validator.spec.ts

README.md

Co-authored-by: Shimon Cohen <[email protected]>

github-actions · 2024-07-23T10:01:27Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-c770b2ebdfe4126e8e365a5113fe8b944ccaff6e.tgz"
  }
}

The link will expire in a week ⌛

github-actions · 2024-07-23T10:25:58Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-b4afec5a00dc6b635e44cd34c493fd928f84ba8f.tgz"
  }
}

The link will expire in a week ⌛

RonitKissis · 2024-07-30T10:45:05Z

"localConfigPath" should be optional, it has a default value

github-actions · 2024-07-31T13:21:48Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-6b31439baecde35d4488e74569bfec3f2eafe7d8.tgz"
  }
}

The link will expire in a week ⌛

src/config.ts

src/validator.ts

github-actions · 2024-08-13T06:34:59Z

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-1ad0a688e4fdb5b3b4e6e511c886d6088de5c6e7.tgz"
  }
}

The link will expire in a week ⌛

CptSchnitz added 7 commits April 11, 2024 15:15

feat: first api poc

0aa5299

feat: progress

0cd8f17

feat: wip

07bed5a

feat: progress

1b4a40d

feat: more progress

b89cd3c

feat: finished error handling

2d1cf6a

feat: added debug

4052293

CptSchnitz requested review from syncush and shimoncohen June 20, 2024 15:10

syncush requested changes Jun 21, 2024

View reviewed changes

shimoncohen requested changes Jun 23, 2024

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

src/env.ts Outdated Show resolved Hide resolved

src/options.ts Show resolved Hide resolved

src/debug.ts Outdated Show resolved Hide resolved

src/env.ts Outdated Show resolved Hide resolved

shimoncohen assigned CptSchnitz Jun 23, 2024

fix: pr changes

0fe3639

refactor: renamed and exported ConfigInstance

0bf937c

fix: exported lodash types for use in get function

5fef476

fix: changed ConfigInstance generics

6b9a2ae

fix: changed ConfigInstance to depends on type instead of on schema

86de770

CptSchnitz added 2 commits June 30, 2024 07:37

refactor: simplified debug msg

5a00dbb

fix: change envOptions to not have the keys instead of being undefined

9746d3f

fix: added keyword to ajv

5d2e00f

CptSchnitz added 2 commits June 30, 2024 07:55

fix: added keyword to correct ajv this time

72b525b

refactor: changed options validator name

f92b966

CptSchnitz added 2 commits July 4, 2024 13:31

feat: added new option to set the local config folder

d3c1d6b

docs: added readme

567d2a3

test: progress

c1fdff2

test: all except config

4f40d19

test: done

4418ce6

style: prettier

f144eb5

shimoncohen requested changes Jul 11, 2024

View reviewed changes

docs: apply suggestions from code review

acdc597

Co-authored-by: Shimon Cohen <[email protected]>

test: apply suggestions from code review

46d8e5b

shimoncohen approved these changes Jul 23, 2024

View reviewed changes

CptSchnitz requested a review from netanelC July 25, 2024 08:39

CptSchnitz marked this pull request as ready for review July 30, 2024 05:40

fix: changed localConfigPath to optional

a9727a3

netanelC requested changes Aug 4, 2024

View reviewed changes

src/config.ts Outdated Show resolved Hide resolved

src/config.ts Outdated Show resolved Hide resolved

src/validator.ts Outdated Show resolved Hide resolved

refactor: requested changes

94d1209

netanelC approved these changes Aug 13, 2024

View reviewed changes

CptSchnitz merged commit 3d04ca0 into master Aug 26, 2024
5 checks passed

CptSchnitz deleted the initial-api branch August 26, 2024 06:17

mapcolonies-devops mentioned this pull request Aug 26, 2024

chore(master): release 1.0.0 #4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: initial api #2

feat: initial api #2

CptSchnitz commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

syncush left a comment

syncush Jun 21, 2024

CptSchnitz Jul 4, 2024

syncush Jun 21, 2024

CptSchnitz Jul 4, 2024

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 30, 2024

github-actions bot commented Jun 30, 2024

github-actions bot commented Jul 4, 2024

github-actions bot commented Jul 4, 2024

github-actions bot commented Jul 7, 2024

github-actions bot commented Jul 8, 2024

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 10, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

RonitKissis commented Jul 30, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Aug 13, 2024

feat: initial api #2

feat: initial api #2

Conversation

CptSchnitz commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

syncush left a comment

Choose a reason for hiding this comment

syncush Jun 21, 2024

Choose a reason for hiding this comment

CptSchnitz Jul 4, 2024

Choose a reason for hiding this comment

syncush Jun 21, 2024

Choose a reason for hiding this comment

CptSchnitz Jul 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 30, 2024

github-actions bot commented Jun 30, 2024

github-actions bot commented Jul 4, 2024

github-actions bot commented Jul 4, 2024

github-actions bot commented Jul 7, 2024

github-actions bot commented Jul 8, 2024

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 10, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

RonitKissis commented Jul 30, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Aug 13, 2024