Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added metrics #15

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat: added metrics #15

merged 3 commits into from
Nov 13, 2024

Conversation

CptSchnitz
Copy link
Collaborator

No description provided.

@CptSchnitz CptSchnitz requested a review from netanelC October 27, 2024 06:18
Copy link

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-5e5b028178bd487b332ca707ce73a9ee6836e025.tgz"
  }
}

The link will expire in a week ⌛

Copy link
Contributor

@netanelC netanelC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you write a script for writing the package version in a created file? Couldn't you just set this in the constants file?

src/types.ts Outdated Show resolved Hide resolved
src/metrics.ts Outdated Show resolved Hide resolved
scripts/generateVersionFile.mjs Show resolved Hide resolved
Copy link

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-3852c3b32ec5d6dd7f8913ac50e850ae0629d941.tgz"
  }
}

The link will expire in a week ⌛

@CptSchnitz CptSchnitz merged commit 94286d3 into master Nov 13, 2024
5 checks passed
@CptSchnitz CptSchnitz deleted the added-metrics branch November 13, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants