fix: made heartbeat client delete heartbeat after completing (MAPCO-5927) #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CL-SHLOMIKONCHA
requested changes
Dec 24, 2024
CL-SHLOMIKONCHA
requested changes
Dec 24, 2024
CL-SHLOMIKONCHA
approved these changes
Dec 24, 2024
nitzanmorr
added a commit
that referenced
this pull request
Dec 24, 2024
…r (MAPCO-4798) (#167) * feat: modify task completed to notify job track but discrete overseer * feat: change callBackUrl location in parameters * fix: made heartbeat client delete heartbeat after completing (MAPCO-5927) (#171) * fix: made heartbeat client delete heartbeat after completing * fix: moved timer stop to the beggining of the Stop function * fix: improve error logging in HeartbeatClient by including exception details * fix: remove parentheses * fix: bumped helm version --------- Co-authored-by: nitzanmorr <[email protected]> Co-authored-by: Nitzan Morr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further information:
This fixes the bug that after completion the job would go back to Pending before being completed