Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps from v0.9.22 to v0.9.26 #720

Merged
merged 22 commits into from
Aug 2, 2022
Merged

Update deps from v0.9.22 to v0.9.26 #720

merged 22 commits into from
Aug 2, 2022

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jul 27, 2022

Signed-off-by: Georgi Zlatarev [email protected]

Description

closes: #719
closes: #623
closes: #659

Manta

Substrate:

Polkadot:

Cumuls:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev self-assigned this Jul 28, 2022
@ghzlatarev ghzlatarev marked this pull request as ready for review July 29, 2022 13:00
@ghzlatarev ghzlatarev changed the title Update deps to v0.9.26 Update deps from v0.9.22 to v0.9.26 Jul 29, 2022
node/Cargo.toml Show resolved Hide resolved
node/src/command.rs Show resolved Hide resolved
pallets/asset-manager/Cargo.toml Outdated Show resolved Hide resolved
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-runtime Area: Issues and PRs related to Runtimes L-changed Log: Issues and PRs related to changes L-added Log: Issues and PRs related to addition labels Aug 1, 2022
@Dengjianping
Copy link
Contributor

Dengjianping commented Aug 1, 2022

Can you align the version of crates like scale-info and codec with polkadot?
Not sure they are aligned. But it's not that important.

@ghzlatarev
Copy link
Contributor Author

scale-info

I think cargo resolves to a single compatible version or it won't compile.

@Garandor
Copy link
Contributor

Garandor commented Aug 1, 2022

i don't think we should allow two L- labels. Something is either changed or added, not both.
@Apokalip can you pls fail your tool if a PR has multiple of these? Only L, multiple A or C labels can be allowed

Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev
Copy link
Contributor Author

i don't think we should allow two L- labels. Something is either changed or added, not both. @Apokalip can you pls fail your tool if a PR has multiple of these? Only L, multiple A or C labels can be allowed

Yeah, there are just abnormal amount of changes in these bump PRs, Neither label is appropriate on its own. Maybe make a new one ?

@Garandor
Copy link
Contributor

Garandor commented Aug 2, 2022

i don't think we should allow two L- labels. Something is either changed or added, not both. @Apokalip can you pls fail your tool if a PR has multiple of these? Only L, multiple A or C labels can be allowed

Yeah, there are just abnormal amount of changes in these bump PRs, Neither label is appropriate on its own. Maybe make a new one ?

I see changed as a superset of added.
Added is a diff that doesn't remove/alter any existing lines - no breaking changers of previous behavior.

@Garandor Garandor removed the L-added Log: Issues and PRs related to addition label Aug 2, 2022
@Apokalip
Copy link
Contributor

Apokalip commented Aug 2, 2022

i don't think we should allow two L- labels. Something is either changed or added, not both. @Apokalip can you pls fail your tool if a PR has multiple of these? Only L, multiple A or C labels can be allowed

Yeah, there are just abnormal amount of changes in these bump PRs, Neither label is appropriate on its own. Maybe make a new one ?

I see changed as a superset of added. Added is a diff that doesn't remove/alter any existing lines - no breaking changers of previous behavior.

We can change labels as we want now. If you put 2 labels it will be added to both those labels. How do we want to handle that? It will not be hard to change either way

@Garandor
Copy link
Contributor

Garandor commented Aug 2, 2022

We can change labels as we want now. If you put 2 labels it will be added to both those labels. How do we want to handle that? It will not be hard to change either way

IMO we should make it consistent and a CI error if more than one L- tag is present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
4 participants