Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong reports of congestion test results #1208

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jul 13, 2023

Description

  • The congestion test results were always being reported as failures, because we were not reading the outputs of previous steps correctly.

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

ghzlatarev and others added 5 commits July 13, 2023 12:09
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev self-assigned this Jul 13, 2023
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-ci Area: Continuous Integration A-testing Area: Testing-related Issues and PRs L-fixed Log: Issues and PRs related to bug fixes labels Jul 13, 2023
@ghzlatarev ghzlatarev marked this pull request as ready for review July 13, 2023 13:17
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

update reported message

Signed-off-by: Georgi Zlatarev <[email protected]>
@Dengjianping
Copy link
Contributor

I found this log

echo "---------------------------------------------------------"
echo failure
echo "---------------------------------------------------------"
```

@Dengjianping
Copy link
Contributor

nvm, it allows to be failed.

@ghzlatarev ghzlatarev merged commit 9b1860b into manta Jul 14, 2023
@ghzlatarev ghzlatarev deleted the ghzlatarev/cong-test branch July 14, 2023 07:01
ghzlatarev added a commit that referenced this pull request Jul 14, 2023
* print to congestion test

Signed-off-by: Georgi Zlatarev <[email protected]>

* print to congestion test

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update check_tests.yml

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update check_tests.yml

Signed-off-by: Georgi Zlatarev <[email protected]>

* Revert push branch

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update check_tests.yml

update reported message

Signed-off-by: Georgi Zlatarev <[email protected]>

---------

Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
ghzlatarev added a commit that referenced this pull request Jul 15, 2023
…equalize Manta and Calamari randomness - 1 epoch ago) (#1216)

* Bump spec version

Signed-off-by: Georgi Zlatarev <[email protected]>

* Use 1 epoch ago randomness in calamari as well

Signed-off-by: Georgi Zlatarev <[email protected]>

* bench only xcm pallets

Signed-off-by: Georgi Zlatarev <[email protected]>

* bench only lotter

Signed-off-by: Georgi Zlatarev <[email protected]>

* bench only lottery and dex

Signed-off-by: Georgi Zlatarev <[email protected]>

* Revert

Signed-off-by: Georgi Zlatarev <[email protected]>

* Bump client

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update changelog

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update xcm weights

Signed-off-by: Georgi Zlatarev <[email protected]>

* Benc pallet-lottery only

Signed-off-by: Georgi Zlatarev <[email protected]>

* recommit

Signed-off-by: Georgi Zlatarev <[email protected]>

* Fix wrong reports of congestion test results (#1208)

* print to congestion test

Signed-off-by: Georgi Zlatarev <[email protected]>

* print to congestion test

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update check_tests.yml

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update check_tests.yml

Signed-off-by: Georgi Zlatarev <[email protected]>

* Revert push branch

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update check_tests.yml

update reported message

Signed-off-by: Georgi Zlatarev <[email protected]>

---------

Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>

* Update changelog

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update lottery weights

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update DCO workflow

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update changelog

Signed-off-by: Georgi Zlatarev <[email protected]>

* Add mantapay rpc tests to manta runtime (#1207)

* Add mantapay rpc tests to manta runtiem

Signed-off-by: Georgi Zlatarev <[email protected]>

* Add avg block time test to mocha tests

Signed-off-by: Georgi Zlatarev <[email protected]>

* Fix avg block test|
|

Signed-off-by: Georgi Zlatarev <[email protected]>

* Add logs

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update average block time test

Signed-off-by: Georgi Zlatarev <[email protected]>

* Don't await in lambda

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update stress_benchmark_test.ts

Signed-off-by: Georgi Zlatarev <[email protected]>

---------

Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>

* Update changelog

Signed-off-by: Georgi Zlatarev <[email protected]>

* Unfilter pallet-xcm send

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update xcmPallet send origin and mocks

Signed-off-by: Georgi Zlatarev <[email protected]>

* Remove redundant comment

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update xcm execute filter

Signed-off-by: Georgi Zlatarev <[email protected]>

---------

Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration A-testing Area: Testing-related Issues and PRs C-enhancement Category: An issue proposing an enhancement or a PR with one L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Congestion test keep reporting failure in PRs even though it succeeds
3 participants