Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn start #36

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

fleboulch
Copy link
Contributor

@fleboulch fleboulch commented Aug 5, 2024

The command yarn start is broken since last commit. This MR is fixing this issue for the development mode

Here is the details about the issue

ERROR (43528):
    message: "Environment variable API_BASE_PATH not found"

@cicoub13
Copy link
Member

cicoub13 commented Aug 5, 2024

Thanks for the catch. Can you put the line first (to respect alphabetical order) ?

@fleboulch fleboulch force-pushed the contrib/fix-yarn-start branch from 2f0179a to c148473 Compare August 5, 2024 13:35
@fleboulch
Copy link
Contributor Author

Fixed :)

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.63%. Comparing base (793053d) to head (c148473).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   75.63%   75.63%           
=======================================
  Files          93       93           
  Lines        1884     1884           
  Branches      365      362    -3     
=======================================
  Hits         1425     1425           
  Misses        450      450           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cicoub13 cicoub13 merged commit 28bbe41 into ManoManoTech:main Aug 5, 2024
3 checks passed
@fleboulch fleboulch deleted the contrib/fix-yarn-start branch August 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants