Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): add release command #26

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

pfongkye
Copy link
Contributor

@pfongkye pfongkye commented Jun 27, 2024

Add release workflow command to enable automatic release of a configured project.

@pfongkye pfongkye force-pushed the feat/release-command branch 2 times, most recently from 933e779 to a0eae86 Compare June 27, 2024 13:49
@pfongkye pfongkye changed the title feat(release): add release and changelog commands feat(release): add release command Jun 27, 2024
@pfongkye pfongkye requested review from greg0ire and cicoub13 June 27, 2024 13:50
@pfongkye pfongkye force-pushed the feat/release-command branch 2 times, most recently from a74e1d1 to 0cdf142 Compare June 27, 2024 14:02
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 63.51931% with 255 lines in your changes missing coverage. Please review.

Project coverage is 75.63%. Comparing base (136e8d7) to head (e55338f).

Files Patch % Lines
...mands/create/hookHandlers/deploymentHookHandler.ts 15.09% 45 Missing ⚠️
.../commands/create/managers/defaultReleaseManager.ts 30.00% 35 Missing ⚠️
...c/release/commands/cancel/selectReleaseToCancel.ts 18.75% 26 Missing ⚠️
...ds/create/viewBuilders/buildReleaseStateMessage.ts 45.00% 22 Missing ⚠️
src/core/services/gitlab.ts 16.66% 15 Missing ⚠️
...nds/create/managers/federationReleaseTagManager.ts 0.00% 15 Missing ⚠️
...ds/create/utils/waitForReadinessAndStartRelease.ts 75.92% 12 Missing and 1 partial ⚠️
.../commands/create/managers/libraryReleaseManager.ts 0.00% 11 Missing ⚠️
...ase/commands/cancel/cancelReleaseRequestHandler.ts 41.17% 10 Missing ⚠️
...mands/create/viewBuilders/buildReleaseModalView.ts 79.59% 8 Missing and 2 partials ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   76.78%   75.63%   -1.16%     
==========================================
  Files          64       93      +29     
  Lines        1189     1884     +695     
  Branches      209      362     +153     
==========================================
+ Hits          913     1425     +512     
- Misses        272      450     +178     
- Partials        4        9       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any docs/README.md changes that should be made?

@pfongkye
Copy link
Contributor Author

Are there any docs/README.md changes that should be made?

I'll check and add a simple message as we would work on how to configure projects for release afterwards.

@pfongkye pfongkye force-pushed the feat/release-command branch from 0cdf142 to e55338f Compare June 27, 2024 14:20
@greg0ire greg0ire merged commit 9fd1ae1 into ManoManoTech:main Jun 27, 2024
1 check passed
@greg0ire
Copy link
Member

Thanks @pfongkye ! Should we delete the release branch?

@pfongkye
Copy link
Contributor Author

Thanks @pfongkye ! Should we delete the release branch?

Yes we can delete the release branch. Thanks.

@pfongkye pfongkye deleted the feat/release-command branch June 28, 2024 07:15
@greg0ire
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants