Gc::from_raw: Set the Gc as a root #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recovered Gc is not inside a GcBox on the heap, so it must be set as a root (like it must have been when it was originally passed to Gc::into_raw). Otherwise, putting it into another Gc will panic with “Can't double-unroot a Gc<T>”. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
force-pushed
the
from_raw-root
branch
from
848843c
to
d495f65
Compare
|
I'm a bit confused, currently |
|
|
|
Ah! I understand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recovered
Gcis not inside aGcBoxon the heap, so it must be set as a root (like it must have been when it was originally passed toGc::into_raw). Otherwise, putting it into anotherGcwill panic with “Can't double-unroot a Gc<T>”.