Skip to content

Commit

Permalink
testsuite: Fix recent GCC FAIL: gdb.arch/i386-signal.exp
Browse files Browse the repository at this point in the history
gcc-6.2.1-2.fc24.x86_64

(gdb) backtrace 10^M
(gdb) FAIL: gdb.arch/i386-signal.exp: backtrace 10

(gdb) disas/s
Dump of assembler code for function main:
.../gdb/testsuite/gdb.arch/i386-signal.c:
30      {
   0x000000000040057f <+0>:     push   %rbp
   0x0000000000400580 <+1>:     mov    %rsp,%rbp
31        setup ();
   0x0000000000400583 <+4>:     callq  0x400590 <setup>
=> 0x0000000000400588 <+9>:     mov    $0x0,%eax
32      }
   0x000000000040058d <+14>:    pop    %rbp
   0x000000000040058e <+15>:    retq
End of assembler dump.

The .exp patch is an obvious typo fix I think.  The regex was written to
accept "ADDR in main" and I find it OK as checking .debug_line validity is not
the purpose of this testfile.

gcc-4.8.5-11.el7.x86_64 did not put the 'mov $0x0,%eax' instruction there at
all so there was no problem with .debug_line.

gdb/testsuite/ChangeLog
2016-10-05  Jan Kratochvil  <[email protected]>

	* gdb.arch/i386-signal.exp (backtrace 10): Fix tromey#2 typo.
  • Loading branch information
jankratochvil committed Oct 5, 2016
1 parent 39b5a3b commit f389f6f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions gdb/testsuite/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2016-10-05 Jan Kratochvil <[email protected]>

* gdb.arch/i386-signal.exp (backtrace 10): Fix #2 typo.

2016-10-05 Yao Qi <[email protected]>

* lib/gdb.exp (support_complex_tests): Return zero if
Expand Down
2 changes: 1 addition & 1 deletion gdb/testsuite/gdb.arch/i386-signal.exp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ gdb_load ${binfile}

runto func
gdb_test "backtrace 10" \
"#0 ($hex in )?func.*\r\n#1 <signal handler called>\r\n#2 ($hex in)?main.*"
"#0 ($hex in )?func.*\r\n#1 <signal handler called>\r\n#2 ($hex in )?main.*"

gdb_test "finish" "Run till exit from \#0 func.*<signal handler called>"

0 comments on commit f389f6f

Please sign in to comment.