preserve non-JSON lines during normalization #172
Conversation
|
@Manishearth @laumann The corresponding rustc PR has been r+'d. Does that mean we can land this here? Both Miri and Clippy had missed test failures because of this, so it seems prudent to fix this quickly. Ideally we'd also carry over the part from rustc's compiletest that checks the exit code of the compiler. However, I have no idea how upstream syncing is handled -- see #175. |
|
Sure, feel free to upstream
…On Wed, Apr 10, 2019, 7:45 AM Ralf Jung ***@***.***> wrote:
@Manishearth <https://github.com/Manishearth> @laumann
<https://github.com/laumann> The corresponding rustc PR
<rust-lang/rust#59769> has been r+'d. Does that
mean we can land this here?
Both Miri and Clippy had missed test failures because of this, so it seems
prudent to fix this quickly.
Ideally we'd also carry over the part from rustc's compiletest that checks
the exit code of the compiler. However, I have no idea how upstream syncing
is handled -- see #175
<#175>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABivSHWNER02ACxGcrLgZmd3L2VzcQlTks5vffkWgaJpZM4cgpCL>
.
|
|
WDYM? I upstreamed this, it is waiting-for-bors. I am asking for it to also land here. |
|
That's what I meant by "upstream", should have said "uplift", sorry. To be clear: go ahead and make a version of your PR for this repo |
|
Uh... this very PR we are talking in is a version of that PR for this repo...? |
|
Oh, I thought this was an issue, my bad
(I don't have great internet right now)
…On Thu, Apr 11, 2019, 1:51 AM Ralf Jung ***@***.***> wrote:
Uh... this very PR we are talking in is a version of that PR for this
repo...?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABivSJQZldGlQ0ZvbAr9jEsHYrXGfI--ks5vfveSgaJpZM4cgpCL>
.
|
|
That's okay. :) I was just terribly confused. ;) |
|
The upstream PR has been merged, it would be nice to get this into compiletest-rs, too =) |
|
(Note that CI is red for different reasons that are fixed by #170.) |
RalfJung
force-pushed
the
json-normalization
branch
from
71f940f to
46c4b13
Compare
|
Rebased to rerun CI. |
|
CI has a happy green :) |
|
@Manishearth can we please merge this? I just spent 2h debugging a really weird issue in Miri where CI on Windows seemed to not catch a problem, until realizing that actually it was this ICEs-are-ignored issue again. |
Fixes #169
I am not sure what the usual process is, do you want the files here to be verbatim identical to what is in rustc? The diff seems quite large currently, at least for
runtest.rs. I will submit the same thing there as well, if it still applies.