Add config to get hashes' keys in snake_case #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new feature that allows users to configure the response hash keys to be in snake_case instead of CamelCase, following the ruby convention. Adding a dependency from 'activesupport', this increases the minimum ruby version to 2.2.2 The new feature is implemented in a way that it does not break existing functionality. There are also additional tests to ensure the correctness of the new feature.
refactor ubo_spec.rb; add method to camelize keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to snakify_keys we receive when calling MangoPay endpoints. This allows us to map objects params 1:1 in the db, without transform them to follow ruby's convention. For example:
default:
=> {"Id"=>"206880768", "UserId"=>"206880767", "CreationDate"=>1697803982, "ProcessedDate"=>nil, "Status"=>"VALIDATION_ASKED", "Reason"=>nil, "Message"=>nil, "Ubos"=>[{"Id"=>"206880769", "CreationDate"=>1697803982, "LastName"=>"Doe", "FirstName"=>"John", "Birthday"=>1300186358, "Nationality"=>"FR", "Address"=>{"AddressLine1"=>"6 Parvis Notre-Dame", "AddressLine2"=>"Pl. Jean-Paul II", "City"=>"Paris", "Region"=>"", "PostalCode"=>"75004", "Country"=>"FR"}, "Birthplace"=>{"City"=>"Paris", "Country"=>"FR"}, "IsActive"=>true}]}snakify_keys = true:
=> {"id"=>"206880772", "user_id"=>"206880771", "creation_date"=>1697803989, "processed_date"=>nil, "status"=>"VALIDATION_ASKED", "reason"=>nil, "message"=>nil, "ubos"=>[{"id"=>"206880773", "creation_date"=>1697803990, "last_name"=>"Doe", "first_name"=>"John", "birthday"=>1300186358, "nationality"=>"FR", "address"=>{"address_line1"=>"6 Parvis Notre-Dame", "address_line2"=>"Pl. Jean-Paul II", "city"=>"Paris", "region"=>"", "postal_code"=>"75004", "country"=>"FR"}, "birthplace"=>{"city"=>"Paris", "country"=>"FR"}, "is_active"=>true}]}This change requires
activesupport, but adding this gem as dependency lead to bump the minimum ruby version to2.2.2, idk if this can be a problem.I've added a bunch of tests and everything seems to be working good. Let me know if further explanations or tests are required