Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the parameter type from int to string in ApiUsers.php function… #644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ali-hassan-careship
Copy link

… GetBankAccount

Since Mangopay has changed the format of Ids, bank account ids have also changed. As a result, now the ids are string instead of integers. My change proposes a change in $bankAccountId parameter data type from int to string on Line 148. The reason from proposing this change is that for me, my project was failing phpsalm and phpstan checks

… GetBankAccount

Since Mangopay has changed the format of Ids, bank account ids have also changed. As a result, now the ids are string instead of integers. My change proposes a change in $bankAccountId parameter data type from int to string on Line 148. 
The reason from proposing this change is that for me, my project was failing phpsalm and phpstan checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants