Add Id
on PayInRecurringRegistration
#565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a big issue, but when we fetch a recurringRegistration by his ID
$this->mangoPayApi->PayIns->GetRecurringRegistration('1234567');
, the result does not have the ID:This could be usefull when we work with a user and we don't know if he already has a recurringRegistration or not, so if not we create it:
This function either return
PayInRecurringRegistrationGet
orPayInRecurringRegistrationRequestResponse
, which both extendsPayInRecurringRegistration
, but onlyPayInRecurringRegistrationRequestResponse
hasId
I also removed
Status
fromPayInRecurringRegistrationRequestResponse
because it's already present inPayInRecurringRegistration