Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/recurring pay in registration #552

Merged
merged 2 commits into from
May 12, 2022

Conversation

H4wKs
Copy link
Contributor

@H4wKs H4wKs commented Apr 28, 2022

Q A
Branch ? Master
Bug Fix ? No
New feature ? Yes
Deprecation ? No
Tickets Fix #546
Licence MIT

This PR add the missing RecurringPayinRegistrationId to all PayIn get calls to match the MangoPay API calls.

Currently, the RecurringPayinRegistrationId is only returned when a RecurringPayinRegistration is created, there is no way to get it later on using the SDK.

I moved RecurringPayinRegistrationId from PayInRecurring class to PayIn class, and keep PayInRecurring as en empty class, just extending PayIn class, this way all the current code will still work the same and we would have a clean logic using PayInRecurring when it make sense from a code point of view, but the RecurringPayinRegistrationId value is stored in the main PayIn object / class.

The only downside of this choice is that RecurringPayinRegistrationId is available in code completion when you create a new PayIn object which could lead to confusion.

I am happy to make changes if you see a better way to achieve this.

Cheers,

Marc

@SoloJr SoloJr merged commit ea47c4c into Mangopay:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PayInRecurringId is missing in Payins (get)
2 participants