Feature/recurring pay in registration #552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the missing RecurringPayinRegistrationId to all PayIn get calls to match the MangoPay API calls.
Currently, the RecurringPayinRegistrationId is only returned when a RecurringPayinRegistration is created, there is no way to get it later on using the SDK.
I moved RecurringPayinRegistrationId from PayInRecurring class to PayIn class, and keep PayInRecurring as en empty class, just extending PayIn class, this way all the current code will still work the same and we would have a clean logic using PayInRecurring when it make sense from a code point of view, but the RecurringPayinRegistrationId value is stored in the main PayIn object / class.
The only downside of this choice is that RecurringPayinRegistrationId is available in code completion when you create a new PayIn object which could lead to confusion.
I am happy to make changes if you see a better way to achieve this.
Cheers,
Marc