Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new PayIn type (External Instruction) #160

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Add new PayIn type (External Instruction) #160

merged 1 commit into from
Jul 5, 2017

Conversation

FelixMalfait
Copy link
Contributor

@FelixMalfait FelixMalfait commented Jul 5, 2017

Hi,

Please fix this ASAP.

This is causing errors for all of our payins in production!

Thanks!

@iammichiel
Copy link
Contributor

LGTM. However, I don't understand why this can break your production?

@FelixMalfait
Copy link
Contributor Author

FelixMalfait commented Jul 5, 2017

We rely on /events and then fetch the payins.

We get the following error:

$mangoPayApi->PayIns->Get(xxx);
PHP error:  Undefined index: EXTERNAL_INSTRUCTION in /app/vendor/mangopay/php-sdk-v2/MangoPay/Libraries/ApiBase.php on line 374

Thanks!

@mickaelpois
Copy link
Contributor

Good evening @FelixMalfait,

Thanks a lot for your help, this completes previous #147 PR.
We will merge it now and release a new version in order to fix your issue.

Mickaël

@mickaelpois mickaelpois merged commit b7fd040 into Mangopay:master Jul 5, 2017
@FelixMalfait
Copy link
Contributor Author

Great, thanks for reacting so quickly!

@mickaelpois
Copy link
Contributor

Dear @FelixMalfait,

Our new 2.5.3 version containing your fix is now available.

@FelixMalfait FelixMalfait changed the title Add new PayIn type (External Instruction) - URGENT ! Add new PayIn type (External Instruction) Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants