Uses passive listeners to improve scrolling performance #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all - thank you for the nice library!
It seems like there is a small space for improvement. I've been running a website audit using google devtools/Lighthouse and I've got this kind of recommendation:
This is it (Learn more link from the screenshot above): https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners?utm_source=lighthouse&utm_medium=devtools
There are a few event listeners (touchstart and touchmove) in the slideout that do not have passive: true on them. That's what I fix with this PR. I didn't commit compiled files
Audit results after the fix: