Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons #9

Merged

Conversation

ripcurlx
Copy link

@ripcurlx ripcurlx commented May 1, 2019

I changed the account level icon to shield (empty, half, full) as I think this gets less confused as the star (rating, mark favorite). I also increased the size of it to make it easier to recognize and as it is more a grouping icon for the additional information icons (delay, can sign). I also went for a slightly changed clock icon (less bold with movement indication). Although we don't want to give the false impression what attestation means for us, I think using a shield is not intuitive. I think an icon with a checkmark would work better for this use-case.
Bildschirmfoto 2019-05-01 um 09 50 19

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner May 1, 2019 07:58
Copy link
Owner

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 969c448 into ManfredKarrer:add-protection-tools May 1, 2019
@ripcurlx ripcurlx deleted the change-icons branch September 26, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants