Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy 0.15 #181

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Bevy 0.15 #181

merged 11 commits into from
Dec 3, 2024

Conversation

bas-ie
Copy link
Contributor

@bas-ie bas-ie commented Nov 30, 2024 •
edited
Loading

It's time for Bevy 0.15! Thanks so much for your work on hexx.

@bas-ie bas-ie marked this pull request as draft November 30, 2024 03:39
@bas-ie
Copy link
Contributor Author

bas-ie commented Nov 30, 2024

(Er, slightly premature PR lol... more coming!)

@bas-ie bas-ie changed the title Bump Bevy to 0.15, glam to 0.29 Bevy 0.15 Nov 30, 2024
@bas-ie bas-ie mentioned this pull request Nov 30, 2024
Merged
ManevilleF
ManevilleF requested changes Dec 1, 2024
View reviewed changes
Copy link
Owner

@ManevilleF ManevilleF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR ! Seeing how many changed bevy 0.15 brought I really appreciate the time you spent updating the examples.
I have 2 comment:

  • I don't think bevy_reflect is needed for all the examples
  • The material wrappers you added in some examples are not needed either, we can use the MaterialMesh3d/2d components directly

As you already spent time on this, I can handle the changes so let me know if you'd rather fix those comments yourself

Cargo.toml Outdated Show resolved Hide resolved
examples/3d_columns.rs Outdated Show resolved Hide resolved
examples/3d_picking.rs Outdated Show resolved Hide resolved
examples/a_star.rs Outdated Show resolved Hide resolved
examples/field_of_view.rs Outdated Show resolved Hide resolved
examples/hex_area.rs Outdated Show resolved Hide resolved
examples/hex_grid.rs Outdated Show resolved Hide resolved
examples/shapes.rs Outdated Show resolved Hide resolved
examples/wrap_map.rs Outdated Show resolved Hide resolved
@bas-ie
Copy link
Contributor Author

bas-ie commented Dec 2, 2024

Yes, apologies, I was playing around with patterns now that Handle<T> is no longer a component. I'll rework this now.

@bas-ie bas-ie marked this pull request as ready for review December 2, 2024 01:47
@bas-ie
Copy link
Contributor Author

bas-ie commented Dec 2, 2024

There, that should be a bit better! Only thing we're still waiting on is a release for bevy_inspector_egui, after which I can update the examples that use it. I see they merged jakobhellermann/bevy-inspector-egui@47f1cb6 yesterday so they should be close!

@bas-ie bas-ie requested a review from ManevilleF December 2, 2024 01:57
@bas-ie
Copy link
Contributor Author

bas-ie commented Dec 3, 2024

I think that's the last of it? Let me know if I missed anything.

ManevilleF
ManevilleF approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@ManevilleF ManevilleF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with doctests I'll fix in a followup, seems unrelated to your work
LGTM !

@ManevilleF ManevilleF merged commit d6c4b9a into ManevilleF:main Dec 3, 2024
8 of 9 checks passed
@ManevilleF ManevilleF mentioned this pull request Dec 3, 2024
Closed
@bas-ie bas-ie deleted the 0.15 branch December 3, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManevilleF ManevilleF ManevilleF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bas-ie @ManevilleF