Add New Product Feature to See Request Logs #22701
Conversation
|
Checked commit DavidResende0@036c61b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
| - :name: Logs | ||
| :description: Display Request Logs | ||
| :feature_type: view | ||
| :identifier: miq_request_show_logs |
There was a problem hiding this comment.
how does this work if you have miq_request_view but no child features? For example:
manageiq/db/fixtures/miq_user_roles.yml
Line 1214 in 5912c45
I assume it shows the logs.
What does the UI do if you modif your role and select all the features below miq_request_view, such as miq_request_show_list, miq_request_show, etc. but exclude miq_request_show_logs? I hope that disables it in the UI for your role.
There was a problem hiding this comment.
Discussed this with @DavidResende0 and he verified that the default behavior for user roles like plain user which have miq_request_view but no child nodes is to be shown in the UI with all child nodes selected and therefore they'd default to showing request logs.
Users can configure roles and remove the option for the request logs for each user role as they see fit.
This is basically what I was asking... if it's opt-in or opt-out. It should be opt-out for most if not all user roles.
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
Backported to |
Add New Product Feature to See Request Logs (cherry picked from commit 05f0539)
Addresses: ManageIQ/manageiq-ui-classic#8772
Related UI Pr: ManageIQ/manageiq-ui-classic#8920