Provide the now required response object to the smtp exception #22268
Conversation
mail gem 2.8.0 added ruby 3.1 support[1] which added net-smtp as an explicit gem dependency because it had recently become an extracted gem. Previously, we used the ruby stdlib version, which was using gem version 0.1.0 in ruby 2.7.0 and 0.2.1 in ruby 3.0.0. Starting with net-smtp 0.2.2, the Net::SMTPError types now require a response object [2] and an optional message. 🤷 [1] https://github.com/mikel/mail/pull/1472/files [2] https://github.com/ruby/net-smtp/pull/26/files
|
I think this should be backported as far back as we'll pull in mail gem 2.8.0. |
|
Seems like they broke semver? |
|
Checked commit jrafanie@fdfbba0 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
@jrafanie We are locked to 2.7.1 on oparin. Should we bump oparin to 2.8.0 and backport this? I'm concerned it might auto-update on us and we might forget to backport this otherwise. |
@Fryguy I'm comfortable with upgrading from 2.7.1 to 2.8.0 and pulling back this change to work with it. The changes don't look that significant and I'd rather find out now. |
mail gem 2.8.0 added ruby 3.1 support[1] which added net-smtp as an explicit gem dependency because it had recently become an extracted gem.
Previously, we used the ruby stdlib version, which was using gem version 0.1.0 in ruby 2.7.0 and 0.2.1 in ruby 3.0.0.
Starting with net-smtp 0.2.2, the Net::SMTPError types now require a response object [2] and an optional message. 🤷
[1] https://github.com/mikel/mail/pull/1472/files
[2] https://github.com/ruby/net-smtp/pull/26/files