[WIP] Search bar component in Cloud Tenant module #9225
Conversation
|
@Fryguy Can you take a look at the ruby changes in this pr. The haml and css changes look fine, just wondering if you had any issues with the ruby code in the pr. |
|
This pr fixes: #9217 |
|
Hi @GilbertCherrie , one of the CIs is failing. Is that a concern? |
|
Its failing on master too. I am currently looking into it don't worry. |
|
@Dhamo1107 can you please rebase this to latest master and push again in order to get the test cases to pass. Also, after rebasing can you squash it all down to one commit. |
…atalog items and removed the duplicate column of vault credentials. Fixed the bug where vault credentials were not appearing in service catalog items and removed the duplicate column of vault credentials. Remove current workflow state if its done Fix guest devices summary page show volume templates in image list view Fix survey table readability Update Workflow State icons Before ====== Icons were working for Tasks Icons were only displaying play for all others After ===== Icons are displaying for all Tasks Updated UI json for May 31st translations From ManageIQ/manageiq#23057 and ManageIQ/manageiq#22969 Update .whitesource to trigger a Mend run Update lodash to 4.17.12 Hide policy simulation button Bump ws from 5.2.3 to 5.2.4 Bumps [ws](https://github.com/websockets/ws) from 5.2.3 to 5.2.4. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.3...5.2.4) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Update Yarn to v4.3.0 Fix child services link Update yarn.lock with latest dependencies Update Yarn to v4.3.1 Prepend ActionView::Helpers::NumberHelper with our NumberHelper Fix request form automation fields Update all carbon packages update moment to 2.29.2 through resolution Fix failing automate specs Add known pending package security issues to a pending list Resolve ActionView::MissingTemplate errors by specifying template Rails 7 now raises this error if you don't specify the template correctly. Specifying templates with "." in the name was deprecated here: https://www.github.com/rails/rails/pull/39164 The interface they want is without periods and for you to specify the formats if it's non-standard. Also, render with no :template, :partial, etc. is also gone in rails 7. Somewhat related issued with helpful information can be found here: https://www.github.com/mileszs/wicked_pdf/issues/1005 Remove redundant tests: we check for these in the response body already Provide backward compatible way to globally set permitted classes This supports rails 7 and 6.1. Similar to the change in: ManageIQ/manageiq#22887 add annotations on summary pages with labels and fix miq_custom_attributes Fix variable table spacing Added existing search bar React component in Cloud Tenant module Fixed rubocop error
|
Checked commit Dhamo1107@03472ef with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
@GilbertCherrie I have rebased my branch to the latest master and squashed all commits into a single commit and the changes have been pushed, Please take a look on it |
|
@Dhamo1107 it looks like you didn't rebase/squash correctly. I see 83 file changes a lot of which are not related to this pr. Can you please fix and I will review again |
|
@GilbertCherrie Shall I create a new branch from the updated master branch, add the code for search bar, and create a new PR? I messed up with the rebase/squash and don't know how to fix it |
|
@Dhamo1107 Yeah if you don't know how to fix it just create a new pr and close this one. |
This PR enhances the search functionality in Compute -> Clouds -> Tenant -> (admin) -> admin (Cloud Object Store Containers, Images, Instances, Security Groups, Cloud Networks, Cloud Subnets, Network Ports, Cloud Volumes).
Changes Included:
Reused SearchBar Component:
The
SearchBarcomponent is reused with theadvanced_searchparameter set to false to simplify the search process.Application Controller Updates:
In the
get_view_process_search_textmethod ofapplication_controller.rb, the logic has been updated to handle the @display instance variable.CSS Adjustments:
Added CSS rules to ensure the search bar appears correctly positioned on the right side of the screen.
Impact:
These changes ensure that the search bar functionality works seamlessly across different views, including images, instances, security groups, cloud volumes, and other entities under the
Tenantin theCloudsmenu.Testing:
Verified that the search bar works correctly for all Cloud Tenant display in the UI. But not executed the Rspec test cases.
Before:
After:
