Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mamoru 35 update fork #7

Merged
merged 450 commits into from
Oct 3, 2022
Merged

Feat/mamoru 35 update fork #7

merged 450 commits into from
Oct 3, 2022

Conversation

sokyrko
Copy link

@sokyrko sokyrko commented Sep 30, 2022

No description provided.

gregnazario and others added 30 commits September 21, 2022 00:46
Max gas calculation was being calculated based on the gas used in
simulation, but it can change between calls.  This adds extra gas
to prevent that.
- added the path condition to trigger the Prover test in CI
msmouse and others added 23 commits September 28, 2022 14:29
* [helm][aptos-node] override NodeConfig with deep merge

* [forge] fix cluster autocleanup label

* [forge] default read cluster prometheus secret

* [helm][aptos-node] merge defaults to empty map

* [forge] prometheus auth tests
* [Docs] Reflowing node docs for October milestone.

* [Docs] Draft update of deployments table.

* [Docs] More edits.

* [Docs] More updates.

* [Docs] More updates.

* [Docs] More updates.

* [Docs] More updates.

* [Docs] Landing page fix.

* [Docs] Minor fix.

* [Docs] Removing some older redirects as the target links have also changed.

* [Docs] Fixing broken link in the whats new doc.

* [Docs] Removing AIT-3 docs that are not reused, fixed broken links.

* [Docs] Using system font for the sidebar label.

* [Docs] Owner doc edits.

* [Docs] Owner doc draft.

* [Docs] Voter doc with new flowchart.

* [Docs] Validator flow and docs.

* [Docs] Connecting to aptos network doc.

* [Docs] Renamed additional doc into shutting down node.

* [Docs] Adding box shadows.

* [Docs] Validator landing page with diagrams.

* [Docs] Removing flowcharts and registering at community platform steps.

* [Docs] Adding redirects.
* [SDK][API] Remove event key endpoint / client code

* Update API spec and TS SDK client

Co-authored-by: bowenyang007 <[email protected]>
With increased gas fees, we were exceeding u64. But we really shouldn't be needing that much money - and it was due to this bug
when run via `cargo nextest -p executor`, GAS_UNIT_PRICE is 100 instead of
0 as in unit tests or when it's run via `cargo nextest --workspace`.
Better to make it work with non-zero gas charge anyway.
Namespace should be optional, this allows for overlapping test runs which could
exhaust capacity, however that risk is already present and this shouldnt be our
defense against overscheduling.

Test Plan: this pr will run forge-continuous and run-forge as pull request which will actually test this! :D
Change the release test to run (for only 5 mins) on PR and also to enable
haproxy on the release test for more confidence around haproxy change.

Test Plan: this workflow will run for a short time on the PR itself
…etter messages (aptos-labs#4456)

Previously wait_for_transaction waited only for 60 seconds, and then failed, even if expiry didn't finish. 

Error message was confusing (timeout vs expired), so clarifying all messages better (so user knows if transaction can still succeed or not)

But it seems very odd to not wait to the expiry time passed in, so fixing that. 

 wait_for_transaction_by_hash(_bcs) are now configurable with:

       server_lag_timeout_after_expiry: Option<Duration>,
       timeout_from_call: Option<Duration>,

First one is to finish at some point if rest endpoint is too stale. second one is if a caller wants absolute timeout (even before expiry)

Previously default would be server_lag_timeout_after_expiry=None and timeout_from_call=60s, and I am putting that for now in all other methods (wait_for_transaction/submit_and_wait/etc), so that their logic is unchanged for now.

I changed in fund cli to wait to completion, and in forge tests which had issues with above.(which is server_lag_timeout_after_expiry=60 or 120s, and timeout_from_call=None).
 we can see later if we want to change that to be default, but not changing any logic before the cut.
…hain-id-33

# Conflicts:
#	.github/ts-tasks/package.json
#	.github/ts-tasks/prune-github-workflow-runs.ts
#	.github/ts-tasks/yarn.lock
#	.github/workflows/continuous-e2e-changing-working-quorum-test copy.yaml
#	.github/workflows/continuous-e2e-changing-working-quorum-test-high-load.yaml
#	.github/workflows/continuous-e2e-compat-test.yaml
#	.github/workflows/continuous-e2e-consensus-stress-test.yaml
#	.github/workflows/continuous-e2e-different-node-speed-and-reliability-test.yaml
#	.github/workflows/continuous-e2e-full-node-reboot-stress-test.yaml
#	.github/workflows/continuous-e2e-graceful-overload-test.yaml
#	.github/workflows/continuous-e2e-network-latency-test.yaml
#	.github/workflows/continuous-e2e-performance-test.yaml
#	.github/workflows/continuous-e2e-release-test.yaml
#	.github/workflows/continuous-e2e-single-vfn-test.yaml
#	.github/workflows/continuous-e2e-state-sync-perf-fullnode-apply-test.yaml
#	.github/workflows/continuous-e2e-state-sync-perf-fullnode-execute-test.yaml
#	.github/workflows/continuous-e2e-state-sync-perf-validator-test.yaml
#	.github/workflows/continuous-e2e-validator-reboot-stress-test.yaml
#	.github/workflows/copy-images-to-dockerhub-on-devnet-or-testnet-push.yaml
#	.github/workflows/copy-images-to-dockerhub.yaml
#	.github/workflows/docker-build-test.yaml
#	.github/workflows/lint-test.yaml
#	.github/workflows/prover-test.yaml
#	.github/workflows/prune-old-workflow-runs.yaml
#	.github/workflows/run-forge.yaml
#	Cargo.lock
#	Cargo.toml
#	aptos-move/aptos-gas/src/gas_meter.rs
#	aptos-move/aptos-vm/src/aptos_vm.rs
#	developer-docs-site/docs/cli-tools/aptos-cli-tool/install-aptos-cli.md
#	developer-docs-site/yarn.lock
#	ecosystem/platform/server/package.json
#	ecosystem/platform/server/yarn.lock
#	ecosystem/typescript/sdk/CHANGELOG.md
#	ecosystem/typescript/sdk/examples/javascript/package.json
#	ecosystem/typescript/sdk/examples/javascript/yarn.lock
#	ecosystem/typescript/sdk/examples/typescript/package.json
#	ecosystem/typescript/sdk/examples/typescript/yarn.lock
#	ecosystem/typescript/sdk/package.json
#	ecosystem/typescript/sdk/src/aptos_account.ts
#	ecosystem/typescript/sdk/src/aptos_client.ts
#	ecosystem/typescript/sdk/src/aptos_types/authentication_key.ts
#	ecosystem/typescript/sdk/src/aptos_types/transaction.ts
#	ecosystem/typescript/sdk/src/coin_client.ts
#	ecosystem/typescript/sdk/src/token_client.ts
#	ecosystem/typescript/sdk/src/transaction_builder/builder.ts
#	ecosystem/typescript/sdk/src/utils/memoize-decorator.ts
#	ecosystem/typescript/sdk/src/utils/test_helper.test.ts
#	ecosystem/typescript/sdk/tsup.config.js
#	ecosystem/typescript/sdk/yarn.lock
#	terraform/fullnode/aws/main.tf
#	terraform/helm/genesis/files/genesis.sh
@sokyrko sokyrko requested a review from amamoru September 30, 2022 15:09
@sokyrko sokyrko merged commit f9ef846 into devnet Oct 3, 2022
@sokyrko sokyrko deleted the feat/mamoru-35-update-fork branch October 3, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.