Fix custom hand poses triggering legacy remove_animation call on Anim…

…ationPlayer.
Malcolmnixon · Jul 5, 2024 · be1acfa · be1acfa
1 parent 849177b
commit be1acfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/VERSIONS.md b/VERSIONS.md
@@ -1,5 +1,6 @@
 # 4.4.0
 - Minimum Godot version changed to 4.2
+- Fix custom hand poses calling legacy remove_animation
 
 # 4.3.3
 - Fix Viewport2Din3D property forwarding

diff --git a/addons/godot-xr-tools/hands/hand.gd b/addons/godot-xr-tools/hands/hand.gd
@@ -339,7 +339,7 @@ func _update_pose() -> void:
 		if open_name == "":
 			open_name = "open_hand"
 			if _animation_player.has_animation(open_name):
-				_animation_player.remove_animation(open_name)
+				_animation_player.get_animation_library("").remove_animation(open_name)
 
 			_animation_player.get_animation_library("").add_animation(open_name, open_pose)
 
@@ -353,7 +353,7 @@ func _update_pose() -> void:
 		if closed_name == "":
 			closed_name = "closed_hand"
 			if _animation_player.has_animation(closed_name):
-				_animation_player.remove_animation(closed_name)
+				_animation_player.get_animation_library("").remove_animation(closed_name)
 
 			_animation_player.get_animation_library("").add_animation(closed_name, closed_pose)