Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MY_PACKAGE_REPLACED action handling in BootReceiver #691

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

nadavfima
Copy link
Contributor

I've added the action to the example's manifest and the README.

Changed the log message to something more generic

As this repository hosts two packages, please ensure the PR title starts with the name of the package that it relates to using square brackets (e.g. [flutter_local_notifications])

Fixes Issue #689

I've added the action to the example's manifest and the README.

Changed the log message to something more generic
@nadavfima
Copy link
Contributor Author

@MaikuB
All done! Let me know if anything is missing...

Copy link
Owner

@MaikuB MaikuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on some minor tweaks. I'll need to try to run ADB to confirm the changes will fix the issue but reckon it'll be fine. Everything else looks good to me :)

@MaikuB
Copy link
Owner

MaikuB commented Jul 2, 2020

Tested it out and it's working great :)

@MaikuB
Copy link
Owner

MaikuB commented Jul 7, 2020

As I haven't heard back for a while and assuming the PR is open for me to edit, I'm going try to make the changes myself to close this and get it out as soon as possible

@MaikuB MaikuB merged commit c9d3558 into MaikuB:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants