Fix/3747/no reload on deleting invisible map #3788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenediktMehl
force-pushed
the
fix/3747/no-reload-on-deleting-invisible-map
branch
from
d8e07af
to
eebda6e
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no reload on deleting invisible map
{Issue/Closes}: #3747
Description
When deleting an invisible map/file, the visible maps are not reloaded.
I decided to implement a custom compare mechanism, instead of dividing the "files" Attribute of the CcModel into "visibleFiles" and "invisibleFiles". I did this, because that would mean a lot of new logic that would have to search for the files in both fields, remove files from arrays, add files to arrays,... which seemed too complex and too inperformant for me.
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Screenshots or gifs