Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching files with get params #24

Open
kevich opened this issue Jun 14, 2018 · 3 comments
Open

Caching files with get params #24

kevich opened this issue Jun 14, 2018 · 3 comments

Comments

@kevich
Copy link
Collaborator

kevich commented Jun 14, 2018

Let's assume we want to load some image from barberry with no cache on client side.

That can be done easily with GET /SomeHash_100x100?{randomNumber} for example GET /SomeHash_100x100?1528962263

But for now we will cache image everytime with all different randomNumber we will pass.

That can lead to increase of used space for cache.

My suggestion is no to take into view GET parameters at all when you're creating cache file, since we do not handle any GET parameters anyhow, and we for sure will return same result no matter what GET parameters you will pass.

@Magomogo
Copy link
Owner

I wonder why you wanted to disable cache at client side. There is no way to replace a document in barberry by a different one. This makes cache always valid.

@kevich
Copy link
Collaborator Author

kevich commented Jun 14, 2018

Well, that was kind of hypothetical example. But the main reason is that I don't see the point in caching all:

/SomeHash_100x100?1
/SomeHash_100x100?2
/SomeHash_100x100?3

if we will get same result

@Magomogo
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants