v5.3.5

README.md

@@ -504,6 +504,11 @@ Releases from v5.0.0 are recommended for Magisk v19.4+.
 Releases from v5.2.5 will only install on Magisk v20+.
 
 ## Changelog
+### v5.3.5  
+- Fixed issue with partition model props not being set correctly.
+- Make sure that simulating ro.product.model is completely disabled when enabling "Force BASIC key attestation".
+- Removed Android versions from the device list when picking a model for "Force BASIC key attestation".
+
 ### v5.3.4  
 - Added a module update check option. See the documentation for details.
 - Added `system_ext` to the list of partitions used for certain props (thank you @simonsmh).

common/util_functions.sh

@@ -1259,7 +1259,7 @@ print_edit() {
 			if [ "$1" != "none" ]; then
 				echo "ro.build.fingerprint=${PRINTCHNG}" >> $1
 			else
-				resetprop -nv ro.build.fingerprint $PRINTCHNG >> $LOGFILE 2>&1
+				resetprop -nv ro.build.fingerprint "$PRINTCHNG" >> $LOGFILE 2>&1
 			fi
 		else
 			log_handler "ro.build.fingerprint not currently set on device. Skipping."
@@ -1295,7 +1295,7 @@ patch_edit() {
 					if [ "$1" != "none" ]; then
 						echo "ro.build.version.security_patch=${SECPATCH}" >> $1
 					else
-						resetprop -nv ro.build.version.security_patch $SECPATCH >> $LOGFILE 2>&1
+						resetprop -nv ro.build.version.security_patch "$SECPATCH" >> $LOGFILE 2>&1
 					fi
 				fi
 			;;
@@ -1616,7 +1616,7 @@ set_partition_props() {
 				if [ "$1" != "none" ]; then
 					echo "${TMPPROP}=${3}" >> $1
 				else
-					resetprop -nv $TMPPROP $3 >> $LOGFILE 2>&1
+					resetprop -nv $TMPPROP "$3" >> $LOGFILE 2>&1
 				fi
 			else
 				log_handler "$TMPPROP not currently set on device. Skipping."
@@ -1640,15 +1640,15 @@ forced_basic() {
 	else
 		BASICATTDEV="$(getprop ro.product.brand)"
 	fi
-  if [ "$BASICATTCUST" ]; then
+	if [ "$BASICATTCUST" ]; then
 		BASICATTMODEL=$BASICATTCUST
-  elif [ "$BASICATTLIST" ]; then
+	elif [ "$BASICATTLIST" ]; then
 		BASICATTMODEL=$BASICATTLIST
-  else
+	else
 		# Find the OEM print file
 		TMPFILE="$(ls $MODPATH/printfiles | grep -i $BASICATTDEV)"
 		BASICATTMODEL="$(get_file_value "$MODPATH/printfiles/$TMPFILE" "BASICATTMODEL=")"
-  fi
+	fi
 	# Write or load values
 	if [ "$1" != "none" ]; then
 		if [ "$1" == "$MODPATH/system.prop" ]; then
@@ -1663,6 +1663,8 @@ forced_basic() {
 			TMPVAL=1
 			if [ "$BASICATTEST" == 0 ]; then
 				log_handler "Enabling forced basic attestation."
+				# Disabling ro.product.model simulation
+				replace_fn "MODELSET" $MODELSET 0 $LATEFILE
 			elif [ "$BASICATTEST" == 1 ] && [ -z "$2" ] && [ -z "$3" ] && [ "$4" != "reset" ]; then
 				TMPVAL=0
 				log_handler "Disabling forced basic attestation."
@@ -1681,7 +1683,7 @@ forced_basic() {
 		else
 			TMPVAL="$(getprop ro.product.device)"
 		fi
-		resetprop -nv ro.product.model $TMPVAL >> $LOGFILE 2>&1
+		resetprop -nv ro.product.model "$TMPVAL" >> $LOGFILE 2>&1
 		set_partition_props "none" "ro.product.model" "$TMPVAL"
 	fi
 }
@@ -1744,13 +1746,13 @@ dev_sim_edit() {
 							if [ "$1" != "none" ]; then
 								echo "${ITEM}=${TMPVALUE}" >> $1
 							else
-								resetprop -nv $ITEM $TMPVALUE >> $LOGFILE 2>&1
+								resetprop -nv $ITEM "$TMPVALUE" >> $LOGFILE 2>&1
 							fi
 						else
 							log_handler "$ITEM not currently set on device. Skipping."
 						fi
 						if [ "$PARTPROPSSET" == 1 ]; then
-							set_partition_props $1 $ITEM $TMPVALUE
+							set_partition_props "$1" $ITEM "$TMPVALUE"
 						fi
 					else
 						log_handler "Changing/writing $ITEM is disabled."

module.prop

@@ -1,6 +1,6 @@
 id=MagiskHidePropsConf
 name=MagiskHide Props Config
-version=v5.3.4-v104
-versionCode=65
+version=v5.3.5-v104
+versionCode=66
 author=Didgeridoohan
 description=Change your device's fingerprint, and/or force basic attestation, to pass SafetyNet's CTS Profile check. Set/reset prop values set by MagiskHide. Change any prop values easily, and set your own custom props.

service.sh

@@ -109,7 +109,7 @@ if [ "$PROPEDIT" == 1 ]; then
 		MODULEPROP=$(echo "MODULE${PROP}" | tr '[:lower:]' '[:upper:]')
 		if [ "$(eval "echo \$$REPROP")" == "true" ]; then
 			log_handler "Changing/writing $ITEM."
-			resetprop -nv $ITEM $(eval "echo \$$MODULEPROP") >> $LOGFILE 2>&1
+			resetprop -nv $ITEM "$(eval "echo \$$MODULEPROP")" >> $LOGFILE 2>&1
 		fi
 	done
 	stop

system/binpath/props

@@ -1155,7 +1155,7 @@ forced_list_pick_menu() {
 			IFS=$(echo -en "\n\b")
 			for ITEM in $PRINTSLIST; do
 				if [ "$(get_first $ITEM)" == "$2" ]; then
-					echo -e "${G}$ITEMCOUNT${N} - $(get_device "$ITEM")"
+					echo -e "${G}$ITEMCOUNT${N} - $(get_device "$ITEM" | sed "s| (.*)||")"
 					ITEMCOUNT=$(($ITEMCOUNT+1))
 				fi
 			done
@@ -1541,7 +1541,8 @@ menu_dev_sim() {
 					if [ "$BASICATTEST" == 0 ]; then
 						echo -e "${G}10${N} - ro.product.model${MODELTXT}"
 					else
-						echo "(Simulating ro.product.model is currently disabled.)"
+						echo -e "     (Simulating ro.product.model is currently ${R}disabled${N}.)"
+						echo ""
 					fi
 					MANMODEN=true
 				else