Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a stack of self._fds_to_close to prevent double closes #481

Merged
merged 8 commits into from
Aug 23, 2022
Merged

use a stack of self._fds_to_close to prevent double closes #481

merged 8 commits into from
Aug 23, 2022

Commits on Jul 17, 2022

  1. Add test for preexec_fn fd double close issue

    @fantix
    fantix committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    b1f4f3d View commit details
    Browse the repository at this point in the history

  2. Update tests/test_process.py 

    Co-authored-by: Thomas Grainger <[email protected]>
    @fantix @graingert
    fantix and graingert authored Jul 17, 2022
    Configuration menu
    Copy the full SHA
    757e39c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. use a stack of self._fds_to_close to prevent double closes 

    and make tests easier to write because the close order is deterministic
and in the order that opens happen in

this should also be a bit faster because list.append is faster
than set.add and we skip a call to os_close(-1) and catching an
OSError exception
    @graingert
    graingert committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    730dd1a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into preexec-fn-double-close

    @graingert
    graingert authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    ddeb5e1 View commit details
    Browse the repository at this point in the history

  3. Update process.pyx

    @graingert
    graingert authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    f4f57f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Update uvloop/handles/process.pyx

    @graingert
    graingert authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    d5fe279 View commit details
    Browse the repository at this point in the history

  2. DRY os_dup call

    @graingert
    graingert committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    5926386 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Merge branch 'master' into preexec-fn-double-close

    @graingert
    graingert authored Aug 14, 2022
    Configuration menu
    Copy the full SHA
    aeb5560 View commit details
    Browse the repository at this point in the history