Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement set_child_watcher in uvloop policy #112

Closed
asvetlov opened this issue Nov 9, 2017 · 1 comment
Closed

Implement set_child_watcher in uvloop policy #112

asvetlov opened this issue Nov 9, 2017 · 1 comment

Comments

@asvetlov
Copy link
Contributor

asvetlov commented Nov 9, 2017

AbstractEventLoopPolicy.set_child_watcher() is part of asyncio protocol.

See aio-libs/aiohttp#2491 for details
1st1 added a commit that referenced this issue Nov 10, 2017
@1st1
Implement Policy.set_child_watcher(). Closes issue #112.
78969a6
1st1 added a commit that referenced this issue Nov 11, 2017
@1st1
Revert "Implement Policy.set_child_watcher(). Closes issue #112."
201cdcf 
This reverts commit 78969a6.
@1st1
Copy link
Member

1st1 commented Nov 11, 2017 •
edited
Loading

I think I'll keep set_child_watcher non implemented. Asyncio's Windows policy doesn't implement it, which suggests us that it's OK for a working policy to not support this API. So my advice is to simply handle NotImplementedError.

@1st1 1st1 closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1st1 @asvetlov