New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #300 #365

Merged

MichMich merged 3 commits into MagicMirrorOrg:develop from gzot:develop

Jun 27, 2016

Contributor

gzot commented Jun 27, 2016

Please send your PR's the develop branch.
Don't forget to add the change to changelog.md.

Does the pull request solve a related issue?

YES

If so, can you reference the issue?

What does the pull request accomplish?

Edit Alert.js file to display title and/or message only if they are provided by the notification.

If it includes major visual changes please add screenshots.

Examples of notifications / alerts :

gzot added 3 commits

June 24, 2016 09:15


          Not display title and/or message if they are not provided (alert module)

b44dcc9


          small fix

ccdc981


          Fix MagicMirrorOrg#300

1b9daa0

MichMich merged commit 491bbac into MagicMirrorOrg:develop

Collaborator

MichMich commented Jun 27, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet