[Security Solution] Improves detections tests (elastic#77295)

* improves 'Creates and activates a new custom rule' test * fixes constant problem * improves 'Creates and activates a new custom rule with override option' test * improves 'Creates and activates a new threshold rule' test * refactor * fixes type check issue * improves assertions * removes unused code * changes variables for constants * improves 'waitForTheRuleToBeExecuted' test * improves readability * fixes jenkins error * refactor * refactor Co-authored-by: Elastic Machine <[email protected]>
MadameSheema · Sep 29, 2020 · 36a4d2d · 36a4d2d
1 parent 7918405
commit 36a4d2d
Show file tree

Hide file tree

Showing 19 changed files with 729 additions and 548 deletions.
diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts
@@ -158,6 +158,7 @@ describe('Alerts', () => {
         });
     });
   });
+
   context('Opening alerts', () => {
     beforeEach(() => {
       esArchiverLoad('closed_alerts');
@@ -204,6 +205,7 @@ describe('Alerts', () => {
         });
     });
   });
+
   context('Marking alerts as in-progress', () => {
     beforeEach(() => {
       esArchiverLoad('alerts');

diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules.spec.ts
@@ -43,6 +43,7 @@ describe('Alerts detection rules', () => {
     waitForAlertsIndexToBeCreated();
     goToManageAlertsDetectionRules();
     waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded();
+
     cy.get(RULE_NAME)
       .eq(FIFTH_RULE)
       .invoke('text')
@@ -56,7 +57,6 @@ describe('Alerts detection rules', () => {
             activateRule(SEVENTH_RULE);
             waitForRuleToBeActivated();
             sortByActivatedRules();
-
             cy.get(RULE_NAME)
               .eq(FIRST_RULE)
               .invoke('text')
@@ -70,7 +70,6 @@ describe('Alerts detection rules', () => {
                     cy.wrap(expectedRulesNames).should('include', seventhRuleName);
                   });
               });
-
             cy.get(RULE_SWITCH).eq(FIRST_RULE).should('have.attr', 'role', 'switch');
             cy.get(RULE_SWITCH).eq(SECOND_RULE).should('have.attr', 'role', 'switch');
           });