Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mysql-for-test #16

Merged
merged 4 commits into from
Jan 14, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ node_js:
- "4"

before_install:
- docker run -d -p 12000:12000 jimexist/sqoop:1.99.7-2
- docker run --name mysql-for-test -e MYSQL_ROOT_PASSWORD=12345678 -d mysql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this password used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just use the built-in one https://docs.travis-ci.com/user/database-setup/#MySQL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqoop 的 link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用这个的话,本机和ci就不一致了吧,比如说,我在.travis.yml里面初始化了一些数据库,但是本机不会初始化。如果我手动在本机初始化的话,那么每次在ci上都是一个新的database,但是我本机的可能会有遗留数据,需要我手动清除。

- docker run --name sqoop-for-test --link mysql-for-test:mysql -d -p 12000:12000 jimexist/sqoop:1.99.7-2

script:
npm run coverage