Add/link api #13

Chyroc-MD · 2017-01-14T06:21:48Z

No description provided.

coveralls · 2017-01-14T06:28:36Z

Coverage increased (+10.6%) to 97.059% when pulling 020d9a8 on Add/link-api into 36fe1e3 on master.

jimexist · 2017-01-14T06:34:48Z

src/index.js

+    return senPostRequest(url, JSON.stringify(body))
+  }
+
+  async updateLinkConfig (oldLinkName, config) {


why is this async and others are not?

jimexist · 2017-01-14T06:35:27Z

src/setLinkOptions.js

+  let connectorName
+  let jdbcDriver
+  let connectionString
+  let fetchSize = linkConfig.hasOwnProperty('fetchSize') ? linkConfig['fetchSize'] : 1000


linkConfig('fetchSize') || 1000

jimexist · 2017-01-14T06:36:16Z

src/setLinkOptions.js

+    const port = linkConfig.hasOwnProperty('port') ? linkConfig['port'] : 3306
+    connectorName = 'generic-jdbc-connector'
+    jdbcDriver = 'com.mysql.jdbc.Driver'
+    connectionString = 'jdbc:mysql://' + linkConfig['host'] + ':' + port + '/' + linkConfig['databaseName']


you can use back tick to do string interpolation

jimexist · 2017-01-14T06:36:48Z

src/setLinkOptions.js

+    throw new Error('linkType must be mysql')
+  }
+  return {
+    'links': [{


what is all this?

是说除了mysql还有什么吗，还是mysql那个的配置是什么含义。前者的话，除了mysql，还有oracle, generic,sftp,kite,kafka,ftp,hdfs。mysql属于generic。我再加个hdfs。

jimexist · 2017-01-14T06:37:23Z

test/link.test.js

+        'username': 'root',
+        'password': '12343456',
+      }
+      await sqoopClient.updateLinkConfig(oldLinkName, config)


what is the return value of this update?

coveralls · 2017-01-14T06:37:28Z

Coverage increased (+10.6%) to 97.059% when pulling 93e09bf on Add/link-api into 36fe1e3 on master.

coveralls · 2017-01-14T06:37:28Z

Coverage increased (+10.6%) to 97.059% when pulling 93e09bf on Add/link-api into 36fe1e3 on master.

coveralls · 2017-01-14T06:37:28Z

Coverage increased (+10.6%) to 97.059% when pulling 93e09bf on Add/link-api into 36fe1e3 on master.

jimexist · 2017-01-14T06:37:46Z

test/link.test.js

+    const linkName = 'test_link_2'
+    await sqoopClient.updateLinkEnable(linkName)
+    const data = await sqoopClient.getLinkByLinkName(linkName)
+    expect(data['links'][0]['enabled'].toString()).to.equal('true')


you don't need toString

jimexist

see comments

…o Add/link-api

jimexist · 2017-01-15T10:06:29Z

src/index.js

+  async deleteLinkAll () {
+    const data = await this.getLinkAll()
+    const deleteList = data['links'].map(link => this.deleteLink(link['name']))
+    return await deleteList


you should await Promise.all(a list of promise) not await a list of promise the latter does not work

coveralls · 2017-01-15T10:09:24Z

Coverage increased (+8.2%) to 94.667% when pulling c0c0955 on Add/link-api into b777f75 on master.

…ad of mysql string

coveralls · 2017-01-15T10:37:53Z

Coverage increased (+8.3%) to 94.805% when pulling f86a7c2 on Add/link-api into b777f75 on master.

jimexist · 2017-01-15T12:50:30Z

src/setLinkOptions.js

+        }
+      ]
+    }
+  } else if (linkConfig['linkType'] === linkType.hdfs) {


tear up this into two smaller functions

….set

coveralls · 2017-01-15T13:53:55Z

Coverage increased (+8.9%) to 95.349% when pulling 2976264 on Add/link-api into b777f75 on master.

jimexist · 2017-01-15T14:38:53Z

src/setLinkOptions.js

+}
+
+export function setCreateLinkRequestBody (linkConfig) {
+  if (linkConfig['linkType'] === linkType.mysql) {


use two separate functions for mysql and hdfs

jimexist

see comment

coveralls · 2017-01-15T15:13:38Z

Coverage increased (+9.0%) to 95.455% when pulling 1919690 on Add/link-api into b777f75 on master.

coveralls · 2017-01-16T03:06:00Z

Coverage increased (+9.0%) to 95.455% when pulling 93f360f on Add/link-api into b777f75 on master.

jimexist · 2017-01-16T03:41:30Z

src/index.js

@@ -21,7 +30,7 @@ export class Hasoop {
  }

  formatUrl ([basicPath, queryObject = {}], ...otherPath) {
-    queryObject['user.name'] = this.userName
+    _.set(queryObject, ['user.name'], this.userName)


i guess ['user.name'] can be user.name

在lodash里面，它是以.分割的，如果直接写user.name的话，就会是user=，而不是user.name=<userName>

Chyroc Chen added 11 commits January 11, 2017 19:02

add tdd test for link

08e1c60

Merge branch 'master' into Add/link-api

8b4d408

link : get all link api

45949d0

add createLinkForMysql test

340f1f6

Merge branch 'master' into Add/link-api

ab09b7b

add getLinkAllForEmpty and deleteLinkAll

b679941

add createLinkForMysql

dabf58a

add updateLinkForMysql and getLinkByLinkName

588f608

add getLinkByConnectorName

6317a9d

add updateLinkDisable and updateLinkEnable

36dfcd0

add getLinkAll

020d9a8

Chyroc-MD requested review from jimexist and ZhengHe-MD January 14, 2017 06:21

Chyroc Chen added 2 commits January 14, 2017 14:29

fix

377fb5b

fix

93e09bf

jimexist reviewed Jan 14, 2017

View reviewed changes

jimexist requested changes Jan 14, 2017

View reviewed changes

Chyroc Chen added 4 commits January 14, 2017 15:01

fix

9d23272

fix

ac456d0

fix for merge

9647134

Merge branch 'master' into Add/link-api

ad3a08f

Merge branch 'Add/link-api' of https://github.com/Madadata/hasoop int…

c0c0955

…o Add/link-api

jimexist reviewed Jan 15, 2017

View reviewed changes

use await Promise.all(a list of promise) and use linkType.mysql inste…

f86a7c2

…ad of mysql string

Chyroc-MD requested review from jimexist and ZhengHe-MD January 15, 2017 10:48

jimexist reviewed Jan 15, 2017

View reviewed changes

src/setLinkOptions.js

}

]

}

} else if (linkConfig['linkType'] === linkType.hdfs) {

Copy link

Member

jimexist Jan 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tear up this into two smaller functions

Chyroc Chen added 2 commits January 15, 2017 21:27

tear up setCreateLinkRequestBody into some smaller function and use _…

96cda19

….set

fix : add merge

2976264

Chyroc-MD requested a review from jimexist January 15, 2017 13:56

jimexist reviewed Jan 15, 2017

View reviewed changes

jimexist requested changes Jan 15, 2017

View reviewed changes

use two separate functions for mysql and hdfs

1919690

Chyroc-MD requested a review from jimexist January 15, 2017 15:13

jimexist approved these changes Jan 15, 2017

View reviewed changes

Chyroc Chen added 2 commits January 16, 2017 10:10

use Object.assign not merge

f5e2f4e

use transform-object-rest-spread not Object.assign

2d4b220

Chyroc-MD requested a review from jimexist January 16, 2017 02:33

Chyroc Chen added 2 commits January 16, 2017 10:36

fix : remove -p in mysql docker

5d0b45a

fix code style : import / lodash / Object

93f360f

Chyroc-MD mentioned this pull request Jan 16, 2017

Add/job api #17

Merged

jimexist reviewed Jan 16, 2017

View reviewed changes

jimexist approved these changes Jan 16, 2017

View reviewed changes

ZhengHe-MD approved these changes Jan 16, 2017

View reviewed changes

Chyroc-MD merged commit 7cf2340 into master Jan 16, 2017

jimexist deleted the Add/link-api branch January 16, 2017 03:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add/link api #13

Add/link api #13

Chyroc-MD commented Jan 14, 2017

coveralls commented Jan 14, 2017 •

edited

Loading

jimexist Jan 14, 2017

jimexist Jan 14, 2017

jimexist Jan 14, 2017

jimexist Jan 14, 2017

jimexist Jan 14, 2017

Chyroc-MD Jan 14, 2017

jimexist Jan 14, 2017

coveralls commented Jan 14, 2017 •

edited

Loading

coveralls commented Jan 14, 2017

coveralls commented Jan 14, 2017

jimexist Jan 14, 2017

jimexist left a comment

jimexist Jan 15, 2017

coveralls commented Jan 15, 2017 •

edited

Loading

coveralls commented Jan 15, 2017 •

edited

Loading

jimexist Jan 15, 2017

coveralls commented Jan 15, 2017 •

edited

Loading

jimexist Jan 15, 2017

jimexist left a comment

coveralls commented Jan 15, 2017

coveralls commented Jan 16, 2017 •

edited

Loading

jimexist Jan 16, 2017

Chyroc-MD Jan 16, 2017

Add/link api #13

Add/link api #13

Conversation

Chyroc-MD commented Jan 14, 2017

coveralls commented Jan 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 14, 2017 • edited Loading

coveralls commented Jan 14, 2017

coveralls commented Jan 14, 2017

Choose a reason for hiding this comment

jimexist left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 15, 2017 • edited Loading

coveralls commented Jan 15, 2017 • edited Loading

Choose a reason for hiding this comment

coveralls commented Jan 15, 2017 • edited Loading

Choose a reason for hiding this comment

jimexist left a comment

Choose a reason for hiding this comment

coveralls commented Jan 15, 2017

coveralls commented Jan 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 14, 2017 •

edited

Loading

coveralls commented Jan 14, 2017 •

edited

Loading

coveralls commented Jan 15, 2017 •

edited

Loading

coveralls commented Jan 15, 2017 •

edited

Loading

coveralls commented Jan 15, 2017 •

edited

Loading

coveralls commented Jan 16, 2017 •

edited

Loading