Add test #1
Merged
Add test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,8 +49,8 @@ MDSearchBox.propTypes = { | |||
|
|
|||
| MDSearchBox.defaultProps = { | |||
| text: '', | |||
| width: 300, | |||
| height: 42, | |||
| // width: 300, | |||
There was a problem hiding this comment.
commented out code should be removed
| @@ -9,7 +9,7 @@ | |||
| -ms-flex-align: center; | |||
| align-items: center; | |||
|
|
|||
| width: 300px; | |||
| /*width: 300px;*/ | |||
There was a problem hiding this comment.
如果default props里面有width，那么这里是可以把width删除的。如果你把default props里面的width删了，那么这里就不能删。我觉得前者比较合理和直观
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please~