Simplify implementation of kernels #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 73.21% 75.57% +2.36%
==========================================
Files 41 41
Lines 4756 4529 -227
==========================================
- Hits 3482 3423 -59
+ Misses 1274 1106 -168 ☔ View full report in Codecov by Sentry. |
sshin23
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I pushed for it, but I admit I was wrong.
I think having two codes (the first using for loops, the second using broadcast) is error-prone, and long-term will just increase the burden on maintenance.
This PR removes the kernels using for loops, and keep only the kernels using broadcasting. Hence removing all duplicates code. That fixes the error I made.