MOI interface moved to ext #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 70.25% 69.89% -0.36%
==========================================
Files 42 40 -2
Lines 4626 3897 -729
==========================================
- Hits 3250 2724 -526
+ Misses 1376 1173 -203 ☔ View full report in Codecov by Sentry. |
3 tasks
frapac
approved these changes
Mar 7, 2024
src/MadNLP.jl
Outdated
| @@ -32,6 +26,6 @@ include(joinpath("KKT", "KKTsystem.jl")) | |||
| include(joinpath("LinearSolvers","linearsolvers.jl")) | |||
| include("options.jl") | |||
| include(joinpath("IPM", "IPM.jl")) | |||
| include(joinpath("Interfaces","interfaces.jl")) | |||
| include("ext.jl") | |||
There was a problem hiding this comment.
I would maybe rename ext.jl as interface.jl or external_interface.jl. What do you think?
There was a problem hiding this comment.
renamed it as extension_templates.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes MOI a weak dependency and conditionally loaded upon
import MathOptInterface.This significantly reduces the initial loading time of MadNLP.
Before
After