Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin hashashin.FxCommands #198

Closed
wants to merge 2 commits into from
Closed

Add plugin hashashin.FxCommands #198

wants to merge 2 commits into from

Conversation

hashashin
Copy link
Contributor

@hashashin hashashin commented May 28, 2024

Checklist:

  • I used the latest version to develop and test the Extension
  • I used the workflow to add the Extension (described here)
  • I have not added any files manually to the Macro-Deck-Extensions repository
  • The added Extension is tested and works
  • The added Extension meets the rules
  • The repository of my Extension meets the required file structure

@github-actions github-actions bot added in-process The extension is currently processed moderator-review-required A moderator needs to check and approve this and removed in-process The extension is currently processed labels May 28, 2024
@hashashin
Copy link
Contributor Author

Hi, any reason this was not approved?

@manuelmayer-dev
Copy link
Member

manuelmayer-dev commented Jun 28, 2024

To be honest, I totally forgot it. But I also found some minor issues:

  • The version of the Tag (0.1) does not match the version in the ExtensionManifest (0.0.1)
  • There is no version tag in the .csproj file, which means the version is set to 1.0.0 (default)
  • The description in the PluginAction should be english

@hashashin
Copy link
Contributor Author

I'll open a new PR with the corrections, thanks.

@hashashin hashashin closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moderator-review-required A moderator needs to check and approve this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants