JOSS paper writing #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 11 11
Lines 2660 2660
Branches 713 713
=======================================
Hits 2525 2525
Misses 49 49
Partials 86 86 ☔ View full report in Codecov by Sentry. |
|
I could have just deleted |
for more information, see https://pre-commit.ci
|
@ThomasHaine How should I cite LLC4320 dataset? |
|
I think the best option is Rocha et al., 2016. |
for more information, see https://pre-commit.ci
ThomasHaine
reviewed
Jul 29, 2023
paper/paper.md
Outdated
|
|
||
|  |
There was a problem hiding this comment.
Split the two panels into two separate figures so they're larger and easier to read.
ThomasHaine
reviewed
Jul 29, 2023
paper/paper.md
Outdated
|
|
||
| ## Interpolation / regridding | ||
|
|
||
| In this subsection, we are going to explore the interpolation/regridding functionality of the package. As an example, we used a realistic simulation of the Kangerdlugssuaq Fjord [@Fraser2018] as an example. This is an MITgcm simulation with very uneven grid spacings, i.e. grids close or in the fjord is much more densely placed than the rest. For the interpolation on sea surface height field, we use all the center grid points of the datasets as well as another 60,000 points in a rectangular region where the model grid points are sparsely places (between 66.5N to 67N, between 28.5W to 34.5 W, 600 in longitudinal direction and 100 in latitudinal direction). As shown in Fig. 1a. The interpolated field matches the background field very well, even when the interpolation is happening close to land ocean interface. | ||
| As an example of seaduck's interpolation/regridding functionality, consider a realistic simulation of the Kangerdlugssuaq Fjord, which is in east Greenland [@Fraser2018]. This is an MITgcm simulation with uneven grid spacing such that grid cells within the fjord are much more densely packed than elsewhere. The goal is to interpolate, and hence regrid, the sea surface height field, $\eta$, to a uniform grid spacing in the southern part of the domain. As shown in Fig. 1a, the interpolated field matches the background field very well, even for points close to land. |
There was a problem hiding this comment.
Clarify what you mean by "matches the background field very well" (?)
ThomasHaine
reviewed
Jul 29, 2023
paper/paper.md
Outdated
|
|
||
| ## Interpolation / regridding | ||
|
|
||
| In this subsection, we are going to explore the interpolation/regridding functionality of the package. As an example, we used a realistic simulation of the Kangerdlugssuaq Fjord [@Fraser2018] as an example. This is an MITgcm simulation with very uneven grid spacings, i.e. grids close or in the fjord is much more densely placed than the rest. For the interpolation on sea surface height field, we use all the center grid points of the datasets as well as another 60,000 points in a rectangular region where the model grid points are sparsely places (between 66.5N to 67N, between 28.5W to 34.5 W, 600 in longitudinal direction and 100 in latitudinal direction). As shown in Fig. 1a. The interpolated field matches the background field very well, even when the interpolation is happening close to land ocean interface. | ||
| As an example of seaduck's interpolation/regridding functionality, consider a realistic simulation of the Kangerdlugssuaq Fjord, which is in east Greenland [@Fraser2018]. This is an MITgcm simulation with uneven grid spacing such that grid cells within the fjord are much more densely packed than elsewhere. The goal is to interpolate, and hence regrid, the sea surface height field, $\eta$, to a uniform grid spacing in the southern part of the domain. As shown in Fig. 1a, the interpolated field matches the background field very well, even for points close to land. |
ThomasHaine
reviewed
Jul 29, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the github action works. let's see