Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test and rename #64

Merged
merged 10 commits into from
Jun 29, 2023
Merged

Move test and rename #64

merged 10 commits into from
Jun 29, 2023

Conversation

MaceKuailv
Copy link
Owner

Rename a bunch of variables.

Move the tests that is left in #62 to unit tests.

@MaceKuailv MaceKuailv temporarily deployed to pypi June 29, 2023 20:54 — with GitHub Actions Inactive
@MaceKuailv
Copy link
Owner Author

This finally adresses issue #17 and mostly resolve issue #33

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 85.06% and project coverage change: +0.27 🎉

Comparison is base (2cf0fe9) 94.65% compared to head (0b9a2e0) 94.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   94.65%   94.92%   +0.27%     
==========================================
  Files          11       11              
  Lines        2655     2641      -14     
  Branches      709      705       -4     
==========================================
- Hits         2513     2507       -6     
+ Misses         53       48       -5     
+ Partials       89       86       -3     
Impacted Files Coverage Δ
seaduck/topology.py 88.13% <65.00%> (ø)
seaduck/eulerian.py 94.82% <86.25%> (ø)
seaduck/kernel_weight.py 95.16% <90.90%> (ø)
seaduck/get_masks.py 96.26% <100.00%> (ø)
seaduck/lagrangian.py 97.37% <100.00%> (+1.62%) ⬆️
seaduck/ocedata.py 96.63% <100.00%> (-0.02%) ⬇️
seaduck/utils.py 95.81% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MaceKuailv
Copy link
Owner Author

By #33 I mean issue #52

This was referenced Jun 29, 2023
@MaceKuailv MaceKuailv merged commit b5a36b3 into main Jun 29, 2023
@MaceKuailv MaceKuailv deleted the move-tests branch June 30, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant