Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #54

Merged
merged 13 commits into from
Jun 18, 2023
Merged

Conversation

ThomasHaine
Copy link
Collaborator

Minor edits in markdown for clarity and style.

@ThomasHaine ThomasHaine temporarily deployed to pypi June 17, 2023 14:10 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (66d9759) 92.81% compared to head (e6f6d15) 92.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          11       11           
  Lines        2629     2629           
  Branches      720      720           
=======================================
  Hits         2440     2440           
  Misses         85       85           
  Partials      104      104           
Impacted Files Coverage Δ
seaduck/utils.py 93.29% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@MaceKuailv MaceKuailv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The error introduced is not purely a round-off error. At the beginning of steps, the particles are "trimmed" to be actually in the cell. Other than that it is all good and ready to be merged.

@ThomasHaine ThomasHaine temporarily deployed to pypi June 18, 2023 11:01 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to pypi June 18, 2023 11:01 Inactive
@ThomasHaine ThomasHaine temporarily deployed to pypi June 18, 2023 15:59 — with GitHub Actions Inactive
@ThomasHaine ThomasHaine temporarily deployed to pypi June 18, 2023 17:38 — with GitHub Actions Inactive
@ThomasHaine ThomasHaine temporarily deployed to pypi June 18, 2023 17:38 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv merged commit 427b255 into MaceKuailv:main Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants