-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test numba and upgrade micromamba #32
Conversation
Also, I think it's enough to only test the most recent/old versions of python supported |
The reason why I didn't use matrix was that numba for Python 3.11 was not available until this week. There was a gap of about half a year long when 3.11 and numba cannot be installed in the same environment (numba/numba#8304). Ideally, I would like to test on the newest available Python version, but I guess it doesn't hurt much to wait until numba is available. Do we need to accommodate that @malmans2? This is what I meant in this comment: #30 (comment) |
Right now you are OK, right? strategy:
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
optional-dependencies: ["", "numba"]
exclude:
- python-version: "3.12"
optional-dependencies: "numba" Of course you can also do the opposite strategy:
matrix:
python-version: ["3.9", "3.10", "3.11"]
optional-dependencies: ["", "numba"]
include:
- python-version: "3.12"
optional-dependencies: "" See https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations and https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations |
That's what I was looking for yesterday! Thanks! It turns out one of the test I recently wrote is not compatible with numba environments. I would like to commit to this branch and test it further. Can you give me commit permission to this branch of yours @malmans2? I got:
|
@MaceKuailv here is a simpler idea to test w and w/o numba.
Closes #30