-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aesthetic #23
Aesthetic #23
Conversation
Good news: we have I have written a little script that process a notebook into a .md file. That repo will also host all of the sciserver specific notebooks in the future. The idea is that, at the end of the day, the dirty stuff has to go somewhere. https://github.com/MaceKuailv/seaduck_sciserver_notebook The sciserver notebooks (just one at this point) here are converted into jupytext-myst style markdown files. And I exclude it from executing. The style check for markdown will break myst notebooks, so I excluded them in the check. This would not be a problem because the conversion from notebook to md is done by jupytext, which has pretty standard way of outputting stuff. This however means that the style check is going to fail for this PR because on the main branch the markdown check still want to fix the notebooks (and break them). |
I was wrong about the style check. @malmans2 what do you think overall? |
Hi @MaceKuailv, looks good!
|
Also, I suggest to print the import seaduck as sd
print(sd.__version__) |
I will go ahead and incorporate the changes in a minute |
Well, I may as well work on issue #26 from this PR as well, even though it is a bit low priority. |
Mainly about the notebooks. Also change the code to make the notebook prettier.