Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetic #23

Merged
merged 18 commits into from
May 23, 2023
Merged

Aesthetic #23

merged 18 commits into from
May 23, 2023

Conversation

MaceKuailv
Copy link
Owner

Mainly about the notebooks. Also change the code to make the notebook prettier.

@MaceKuailv MaceKuailv temporarily deployed to pypi May 21, 2023 18:58 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 02:10 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 02:13 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 02:14 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 20:53 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 20:57 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 21:31 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 21:56 — with GitHub Actions Inactive
@MaceKuailv
Copy link
Owner Author

Good news: we have execute: auto

I have written a little script that process a notebook into a .md file. That repo will also host all of the sciserver specific notebooks in the future. The idea is that, at the end of the day, the dirty stuff has to go somewhere.

https://github.com/MaceKuailv/seaduck_sciserver_notebook

The sciserver notebooks (just one at this point) here are converted into jupytext-myst style markdown files. And I exclude it from executing.

The style check for markdown will break myst notebooks, so I excluded them in the check. This would not be a problem because the conversion from notebook to md is done by jupytext, which has pretty standard way of outputting stuff. This however means that the style check is going to fail for this PR because on the main branch the markdown check still want to fix the notebooks (and break them).

@MaceKuailv MaceKuailv temporarily deployed to pypi May 22, 2023 22:04 — with GitHub Actions Inactive
@MaceKuailv
Copy link
Owner Author

I was wrong about the style check.

@malmans2 what do you think overall?

@malmans2
Copy link
Contributor

Hi @MaceKuailv, looks good!
All notebook in this repo will be executed when the documentation is compiled, right?
If yes, I would add the pre-commit hook that strips all notebook output:

- repo: https://github.com/kynan/nbstripout
  rev: 0.6.1
  hooks:
  - id: nbstripout

@malmans2
Copy link
Contributor

Also, I suggest to print the seaduck version in the SciServer notebook:

import seaduck as sd

print(sd.__version__)

@MaceKuailv
Copy link
Owner Author

I will go ahead and incorporate the changes in a minute

@MaceKuailv MaceKuailv temporarily deployed to pypi May 23, 2023 15:15 — with GitHub Actions Inactive
@MaceKuailv
Copy link
Owner Author

Well, I may as well work on issue #26 from this PR as well, even though it is a bit low priority.

@MaceKuailv MaceKuailv temporarily deployed to pypi May 23, 2023 16:27 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi May 23, 2023 16:38 — with GitHub Actions Inactive
@MaceKuailv
Copy link
Owner Author

Address issue #13 #26 #27. The documentation certainly can use some improvement, but that's enough for this PR.

@MaceKuailv MaceKuailv merged commit 82474e9 into main May 23, 2023
@MaceKuailv MaceKuailv deleted the aesthetic branch May 23, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants