Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dic #121

Merged
merged 26 commits into from
Jul 8, 2024
Merged

Dic #121

merged 26 commits into from
Jul 8, 2024

Conversation

MaceKuailv
Copy link
Owner

Various changes I made for the DIC thing.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 50.56818% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 76.82%. Comparing base (8055b00) to head (ff24a1b).

Current head ff24a1b differs from pull request most recent head 963603d

Please upload reports for the commit 963603d to get more accurate results.

Files Patch % Lines
seaduck/eulerian.py 8.69% 63 Missing ⚠️
seaduck/eulerian_budget.py 80.41% 19 Missing ⚠️
seaduck/ocedata.py 40.00% 1 Missing and 2 partials ⚠️
seaduck/lagrangian.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #121       +/-   ##
===========================================
- Coverage   88.81%   76.82%   -11.99%     
===========================================
  Files          13       13               
  Lines        3094     3254      +160     
  Branches      754      777       +23     
===========================================
- Hits         2748     2500      -248     
- Misses        252      669      +417     
+ Partials       94       85        -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaceKuailv
Copy link
Owner Author

#120 seems to be resolved

@MaceKuailv MaceKuailv merged commit dfd63ec into main Jul 8, 2024
10 checks passed
@MaceKuailv MaceKuailv mentioned this pull request Jul 8, 2024
@MaceKuailv MaceKuailv deleted the dic branch July 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant