Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The budget support for seaduck #118

Merged
merged 25 commits into from
Mar 25, 2024
Merged

The budget support for seaduck #118

merged 25 commits into from
Mar 25, 2024

Conversation

MaceKuailv
Copy link
Owner

There is going to be a lot of back and forth.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 60.32720% with 194 lines in your changes are missing coverage. Please review.

Project coverage is 88.81%. Comparing base (e0ec9a7) to head (54c4c13).

Files Patch % Lines
seaduck/eulerian_budget.py 0.00% 129 Missing ⚠️
seaduck/lagrangian_budget.py 86.64% 32 Missing and 3 partials ⚠️
seaduck/utils.py 72.36% 21 Missing ⚠️
seaduck/lagrangian.py 53.33% 3 Missing and 4 partials ⚠️
seaduck/ocedata.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   94.28%   88.81%   -5.47%     
==========================================
  Files          11       13       +2     
  Lines        2658     3094     +436     
  Branches      712      754      +42     
==========================================
+ Hits         2506     2748     +242     
- Misses         66      252     +186     
- Partials       86       94       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaceKuailv
Copy link
Owner Author

this commit's issue is just the test is not enough.

@MaceKuailv MaceKuailv merged commit 8055b00 into main Mar 25, 2024
10 of 12 checks passed
@MaceKuailv MaceKuailv deleted the budget branch March 25, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant